From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Vesker Subject: Re: [PATCH net-next 0/9] devlink: Add support for region access Date: Wed, 4 Apr 2018 14:07:08 +0300 Message-ID: References: <1522339672-18273-1-git-send-email-valex@mellanox.com> <20180329171359.GA12150@lunn.ch> <962b56c1-d471-97ec-e8e9-18252e809dfe@mellanox.com> <20180329195154.GB15565@lunn.ch> <28b99a08-1967-3044-4010-0faa5d6bfc14@mellanox.com> <20180330143403.GD28244@lunn.ch> <6d55f271-18f9-9ca5-0dbf-24951dd09978@gmail.com> <98477af6-b774-48bd-f663-28a7f9f554e3@mellanox.com> <86ebf2c1-dcdf-bfad-f1b8-cf73acf08ddc@gmail.com> <20180331155345.GA14758@lunn.ch> <5790065d-1eb3-ceb5-3f3d-17babd7d77c2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , , "Tariq Toukan" , Jiri Pirko To: David Ahern , Andrew Lunn Return-path: Received: from mail-eopbgr50078.outbound.protection.outlook.com ([40.107.5.78]:25184 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750915AbeDDLH7 (ORCPT ); Wed, 4 Apr 2018 07:07:59 -0400 In-Reply-To: <5790065d-1eb3-ceb5-3f3d-17babd7d77c2@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 3/31/2018 8:21 PM, David Ahern wrote: > On 3/31/18 9:53 AM, Andrew Lunn wrote: >>> I want to be able to login to a customer and accessing this snapshot >>> without any previous configuration from the user and not asking for >>> enabling the feature and then waiting for a repro...this will help >>> debugging issues that are hard to reproduce, I don't see any reason >>> to disable this. >> The likely reality is 99.9% of these snapshots will never be seen or >> used. But they take up memory sitting there doing nothing. And if the >> snapshot is 2GB, that is a lot of memory. I expect a system admin >> wants to be able to choose to enable this feature or not, because of >> that memory. You should also consider implementing the memory pressure >> callbacks, so you can discard snapshots, rather than OOM the machine. >> > That is exactly my point. Nobody wants one rogue device triggering > snapshots, consuming system resources and with no options to disable it. OK, currently there is a task to support persistent/permanent configuration to devlink. Once this support is in I will add my code on top of it. This will allow a user to enable the snapshot functionality on the driver. Regarding the double continuous allocation of memory, I will fix to a single vmalloc on the driver in case of adding a snapshot. Tell me what you think.