From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B79C47092 for ; Tue, 1 Jun 2021 13:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BF4B60C3E for ; Tue, 1 Jun 2021 13:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234048AbhFANn3 (ORCPT ); Tue, 1 Jun 2021 09:43:29 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44776 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234017AbhFANn1 (ORCPT ); Tue, 1 Jun 2021 09:43:27 -0400 Received: from mail-ej1-f70.google.com ([209.85.218.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lo4eP-0005y5-Km for netdev@vger.kernel.org; Tue, 01 Jun 2021 13:41:45 +0000 Received: by mail-ej1-f70.google.com with SMTP id qk29-20020a170906d9ddb02903e6eb7046f6so3272605ejb.4 for ; Tue, 01 Jun 2021 06:41:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8D2cU9WIH4f91nUainalgp07qa8uXynan7ov41ItFDk=; b=DVxWMoqk0yr5rkbxXEB0Vcg+fDMyMnmX1sISSB06VKvnaCniF0o+zk+YpQticp2YzE LIFlCpwpCrW+jJ4E698swHsnaaetCvZAO7NmTlwtccvKT/9yXpnOWVL0Umz5NaZtGRyL PkzonXSl1re58kCw30GilhEoHTIhl6rmMAzGeAfayYJyJIYf2tdVctWgnhT9vPUdzNIL FmvPtzL+qsQa3jzF/lfu5svxZlkEHZCpwmsvS3OqKJRQrFjKcdK3LPJW8ve9OjUYsrF1 713NTRbq37nL9AWNXdO8M0NA3his1gqj67G+/OIcVxELNoRgRTlY6QL4IzJT6xYNbXVP e9Ig== X-Gm-Message-State: AOAM532R2NYSgGyqb+dJhZXYH9U+st4PNpCk5VLxWLraibi4JMavONs8 +KHYX9nNr2bbnA4EIKXKgg2oAGyJZpmOKl1kAiEYGPiWQQnWJgidsgWUAUAIFQBsPm+TZPbk5J2 IWbc1V7SrQKZoouF8y8DzPoXsK0NZ9/8sMg== X-Received: by 2002:a17:906:b2d6:: with SMTP id cf22mr15717471ejb.29.1622554905366; Tue, 01 Jun 2021 06:41:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx9+gdpxkVKY3CEoYk/875InpWjxEeImRktiHYPYvqmpR6IVMcbrWVE/3CTLN0JX3pwP5fLg== X-Received: by 2002:a17:906:b2d6:: with SMTP id cf22mr15717452ejb.29.1622554905191; Tue, 01 Jun 2021 06:41:45 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-185-9.adslplus.ch. [188.155.185.9]) by smtp.gmail.com with ESMTPSA id dk9sm7224352ejb.91.2021.06.01.06.41.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 06:41:44 -0700 (PDT) Subject: Re: [PATCH v2] NFC: microread: Remove redundant assignment to variable err To: Nigel Christian Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Krzysztof Kozlowski Message-ID: Date: Tue, 1 Jun 2021 15:41:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/06/2021 15:35, Nigel Christian wrote: > In the case MICROREAD_CB_TYPE_READER_ALL clang reports a dead code > warning. The error code assigned to variable err is already passed > to async_cb(). The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Nigel Christian > --- > drivers/nfc/microread/microread.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nfc/microread/microread.c b/drivers/nfc/microread/microread.c > index 8d3988457c58..b1d3975e8a81 100644 > --- a/drivers/nfc/microread/microread.c > +++ b/drivers/nfc/microread/microread.c > @@ -364,7 +364,6 @@ static void microread_im_transceive_cb(void *context, struct sk_buff *skb, > case MICROREAD_CB_TYPE_READER_ALL: > if (err == 0) { > if (skb->len == 0) { > - err = -EPROTO; > kfree_skb(skb); > info->async_cb(info->async_cb_context, NULL, > -EPROTO); > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof