From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 15/18] ipv6: Flush multipath routes when all siblings are dead Date: Sun, 7 Jan 2018 10:08:22 -0700 Message-ID: References: <20180107104518.31693-1-idosch@mellanox.com> <20180107104518.31693-16-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:36775 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754121AbeAGRIY (ORCPT ); Sun, 7 Jan 2018 12:08:24 -0500 Received: by mail-pf0-f193.google.com with SMTP id 23so1633978pfp.3 for ; Sun, 07 Jan 2018 09:08:24 -0800 (PST) In-Reply-To: <20180107104518.31693-16-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/7/18 3:45 AM, Ido Schimmel wrote: > By default, IPv6 deletes nexthops from a multipath route when the > nexthop device is put administratively down. This differs from IPv4 > where the nexthops are kept, but marked with the RTNH_F_DEAD flag. A > multipath route is flushed when all of its nexthops become dead. > > Align IPv6 with IPv4 and have it conform to the same guidelines. > > In case the multipath route needs to be flushed, its siblings are > flushed one by one. Otherwise, the nexthops are marked with the > appropriate flags and the tree walker is instructed to skip all the > siblings. > > As explained in previous patches, care is taken to update the sernum of > the affected tree nodes, so as to prevent the use of wrong dst entries. > > Signed-off-by: Ido Schimmel > --- > net/ipv6/route.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 75 insertions(+), 8 deletions(-) Acked-by: David Ahern