From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DE5329C54 for ; Tue, 9 Jun 2026 21:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781040714; cv=none; b=tvmyyWb8BMiqgkR4mR+UiOxhQOLP7kq1tcBQCgqNUATZh3EgRiIlqC1QH9e1A6p0kSNCdP2sbhzRiAvipJUGj41lKiurfBtaqO/EBeHAsp4TmEkYpJY8eR/CMW2nTprOWXVjb0+LiswI/vyAeU9hSsttGMIXHYCT5lxbz9k4bOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781040714; c=relaxed/simple; bh=u02KRuZlQFzGkv6nJNfx75RixQFD4xM54PRC9sX+TeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P8RUFUep/rYy04eKRHFreCDT3wcRu0gGuctMdUy1RuyIxsEeMxBClcfh2AY4DwOuX3c05Ry2ifPgc2pkRNCSmB8Ou2VhOZK0jEIR6Vw/49YlQHegs7sLgJrhGT2W//JW9idbvILfk3jDB3is+MlT2BN/sZfef9OAI0IKGDqimd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=mfqFmqt+; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="mfqFmqt+" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-4863eae4526so2690464b6e.0 for ; Tue, 09 Jun 2026 14:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1781040712; x=1781645512; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aGjz6oXrvv0vYyL9h564g5u9rOXsQ9Yj+tb2sJWaYA0=; b=mfqFmqt+WJx8NSYfElhOBMTg++c3r8Yq+qOtPE6j+Rp39nGafXgFVejdw+XX6c1G8Y WtGm1CHAjgdwVPbNMbusNhxrPEgqJ8ftBfI1CDBJrDXH58mf1cQs3T3t56ngL+brvLLL mDkoPrurq+wWZP9/d3whgV2TL2M9jI29yrLoMadcZACt5Jkj7gMG0WC2DmIrIOQ1lWJ4 C84XQsZVeKsgRr9YkfYO+eZ6f41JO+z9W/2xJUO0ziqf9pp4rDolAUM9CN+pWjUre6Ew KJLk2jUKoV5kpdOXgZjpUwWgg+0QmjaoZ/mmlgLndXknfUAZwyoJGFNJ8tQSbUdtBZ4z v8IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781040712; x=1781645512; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aGjz6oXrvv0vYyL9h564g5u9rOXsQ9Yj+tb2sJWaYA0=; b=cNLeRNZOBNAe4ndhlP4caAaRk0mwSgADsQixZdbc2YRiA1FpULWPRvClHIAg5KhKQE 1wnWqvRYiiTANfwbSBgxaQQA7fMS3N0cFfITMG7xkWF+7ebAylPfHAn5ntc97D69FJlU 5iTyiSj1RLoq/Dt02aheSVAVYy/jflkxHRMcoxt1ms2nUiCQs54BYTsBgGQtaUiEtRuM Ta3NPAZPGk7+kqkjnxPxHpxq0i/CIDoMghMdb/hwShM15iuGJkCVBUwr0YtPfmknCirL R7zl3ncw85yJkeAGICHb2x02128yVQrXAdWUkIfxDkMqE2n4hSUZgttSTqcwWvWYQn2s W/7w== X-Forwarded-Encrypted: i=1; AFNElJ9u+tU5JakTAE4+Ca01iJTzUBitwkaKQY8UhopbHuA+mX7rZBA6JJy+6XDvyxlMQHHSnIobIWw=@vger.kernel.org X-Gm-Message-State: AOJu0YxlBn7VG+4EwNMFj8UU9Sv7gQUAyxORxnTrQz2XMQT9/hTF9Z+W pTtk+l6Ilpwyl6C2DYh0Ha/+n02vWoXEwe2BuM5AzQhwHGxg1d+o0EPlk0wCaPR4QjQ= X-Gm-Gg: Acq92OHAcIf0BNHVTVl5rPgU4gyO0leNYLUSNj9nBV8x/Qrzv8qfZOqnk09f4n7FNqx QYqTFpG3+Gbd0L+PsxUEdUEHIudL1vkxvl8DT0xUeKhDRzDjM1syFNrJKg7wHcw6B8lS57YzZ6C NX9WoIWKqd2suLAFljD/+s5bEjpeyniEulsnZqGwtf7sI7gW5UqMJw6CMzSYZFQk/NVLqUK3MxE CljjDFfhAWs3DntMez5Rrd7o84r25HNeT8dokwdHvkLwXQVSBkYi3462QogBsJ9M4haxWaXkrDL jb79YqXmXf/e/NJ7H9nAFfisV4Km6khf3bF67jGa8jxl54ollZVZa+BwSGJVaAlnLN+Qm8gpU1t zb+p/7aK5yJWm+Xh+3fCCWdXzpFa77hFneqSMXVZCHOA5aac0Y9OaFVstf/LwYu4EjvLO+eIbBK vbH5VXUZt5j+JzeR4tF+qhj/qC3pZmdPGRmg== X-Received: by 2002:a05:6808:191e:b0:47b:bd7b:10e5 with SMTP id 5614622812f47-4868db2d9eamr11794474b6e.3.1781040712262; Tue, 09 Jun 2026 14:31:52 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4865b5a5a64sm17024127b6e.4.2026.06.09.14.31.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 14:31:51 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 16:31:48 -0500 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 10/14] dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge To: Rob Herring Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, Daniel Thompson , mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260605010022.968612-1-elder@riscstar.com> <20260605010022.968612-11-elder@riscstar.com> <20260605144032.GA3659201-robh@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20260605144032.GA3659201-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/5/26 9:40 AM, Rob Herring wrote: > On Thu, Jun 04, 2026 at 08:00:17PM -0500, Alex Elder wrote: >> From: Daniel Thompson >> >> Add devicetree bindings for the Toshiba TC956x family of Ethernet-AVB/TSN >> bridges. >> >> The TC9564 contains a PCIe switch with one upstream and three downstream >> PCIe ports. The third PCIe downstream port has an attached embedded PCIe >> endpoint, and that endpoint implements two PCIe functions. Each internal >> PCIe function has a Synopsys XGMAC Ethernet interface capable of 10 Gbps >> operation. >> >> The TC9564 also implements an embedded GPIO controller, which exposes >> 10 lines externally. Some platforms use these GPIO lines, so this >> GPIO controller is managed by a separate driver. Other embedded >> peripherals (like a microcontroller, SRAM, and UART) are currently >> unused. >> >> The GPIO controller is managed by registers accessed via MMIO on an >> internal PCIe function's registers. >> >> Signed-off-by: Daniel Thompson >> Signed-off-by: Alex Elder >> --- >> .../bindings/net/toshiba,tc9564-dwmac.yaml | 120 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 126 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml b/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml >> new file mode 100644 >> index 0000000000000..6e7a63dfcf86a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml >> @@ -0,0 +1,120 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/toshiba,tc9564-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Toshiba TC956x Ethernet-AVB/TSN Controller >> + >> +maintainers: >> + - Alex Elder >> + - Daniel Thompson >> + >> +description: | >> + The Toshiba TC9564 (and more generally, TC956x) incorporates a PCIe >> + gen 3 switch with one upstream and three downstream ports. The first >> + two downstream ports are exposed externally, while the third is used >> + by an internal PCIe endpoint. The PCIe endpoint implements two PCIe >> + functions, and attached to each of these is a 10 Gbps capable Synopsys >> + Ethernet controller. >> + >> + The TC956x additionally implements other internal IP blocks, and in >> + particular it implements a GPIO controller. Ten of the 35 GPIO lines >> + implemented are exposed externally and are usable by the platform. >> + It is platform-dependent whether the GPIO function must be exposed, >> + and if it is, PCIe function 0 supplies it. >> + >> + ---------------------------------- >> + | Host | >> + ------+...+----------+........+--- >> + |i2c| | PCIe | >> + ----------------+...+----------+........+------ >> + | TC956x |I2C| |upstream| | >> + | ----- --+--------+--- | >> + | ----- ------ ------- | PCIe switch | | >> + | |SPI| |GPIO| |reset| | | | >> + | ----- ------ |clock| | DS3 DS2 DS1 | | >> + | ------- ---++--++--++-- | >> + | ----- ------ downstream// \\ \\ | downstream >> + | |MCU| |SRAM| /==========/ \\ \===== PCIe port 1 >> + | ----- ------ //PCIe port 3 \\ | >> + | || \======= downstream >> + | ----+-----------++-----------+---- | PCIe port 2 >> + | | M | internal PCIe endpoint | M | | >> + | | S |------------------------| S | ------ | >> + | | I | PCIe | | PCIe | I | |UART| | >> + | | G |function 0| |function 1| G | ------ | > > I don't see nodes for these PCI functions. Boot this platform with > CONFIG_PCI_DYNAMIC_OF_NODES enabled and use the resulting DT node > structure. Anything else is wrong. This will give you the DTS: > > dtc -O dts /proc/device-tree > > The ethernet nodes should be just these PCI function nodes. You need to > make the DWMAC PCI driver (stmmac_pci.c) bind to those 2 PCI devices. > And really, a DT node for them should be completely optional (unless > there's some power on ctrl needed). > > Everything else like SPI, GPIO, UART, etc. should be under the PCIe > switch upstream node in a pci-ep-bus. I unfortunately hadn't looked closely enough at pci-ep-bus before. It really looks like what we should use. It's a simple bus, and we'll use platform drivers and compatible strings to match the devices on the bus. I'll work toward converting things over to use this model. > > >> + | | E |----++----| |----++----| E | | >> + | | N | eMAC 0 | | eMAC 1 | N | | >> + --------+.......+------+.....+----------------- >> + |USXGMII| |SGMII| >> + --+.......+-- --+.....+-- >> + | ARQ113C | | QEP8121 | >> + | PHY | | PHY | >> + ------------- ----------- >> + >> +properties: >> + compatible: >> + enum: >> + - pci1179,0220 # Toshiba TC9564 (a.k.a. Qualcomm QPS615) >> + >> + gpio: >> + type: object >> + description: Embedded GPIO controller >> + $ref: /schemas/gpio/gpio.yaml# > > gpio.yaml alone does not define a GPIO controller. How many #gpio-cells > needs to be defined. > > Is there no address associated with the controller? > >> + >> + ethernet: >> + type: object >> + description: XGMAC Ethernet controller >> + $ref: /schemas/net/ethernet-controller.yaml# >> + properties: >> + mdio: >> + $ref: snps,dwmac.yaml#/properties/mdio > > Either all of snps,dwmac.yaml should apply or none of it. Generally, we > only reference whole schema files (OF graph being a notable exception). OK. > >> + required: >> + - mdio >> + >> +required: >> + - compatible >> + >> +allOf: >> + - $ref: /schemas/pci/pci-device.yaml# >> + - $ref: /schemas/pci/pci-bus-common.yaml# > > These 2 are just pci-pci-bridge.yaml. OK. -Alex > > Rob