From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E294DC43381 for ; Fri, 15 Feb 2019 10:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE3DC20685 for ; Fri, 15 Feb 2019 10:44:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U7HVEV9I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730291AbfBOKoB (ORCPT ); Fri, 15 Feb 2019 05:44:01 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41124 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730234AbfBOKoB (ORCPT ); Fri, 15 Feb 2019 05:44:01 -0500 Received: by mail-lf1-f67.google.com with SMTP id e27so6823627lfj.8 for ; Fri, 15 Feb 2019 02:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=jxlgpDd+mQ3yDZUUi/P5b7cqPnXdlSqah1zjBBDwCYI=; b=U7HVEV9IfYU2wP0QqJD7DFeROe3tdtDhT19ASkRKM0LCqg/9Qfee8m+bOgVaoZb4yr rUDbsMbY5ahMvuvptmrgL4gmyR5RStTc8pEtJx0cWvJaSRiHaJMQJC2PKg87RK3x9o5/ enI2/eDH8kY6P/hjHLoWv4L6/pdmjyZeIU7TYDW6TgPLN+GajlCMiBlXzb4YK1Sz3HSA Yc6LWEHzzrwXMNGezSmbpUTsP4isFdxlobUxjUH5a9R5qRBuJVL1kEW3bckOV1O0ZtpU xb8kJ6rYWX0y0hJgBZeqXhL5UYTH1pefL33C5RqKtx8QaBAfCTfVz0QgR57QnjLhrz+w 5n6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=jxlgpDd+mQ3yDZUUi/P5b7cqPnXdlSqah1zjBBDwCYI=; b=mwGQeSLQFqsciaXHtmaGikuKJvqx4bl+yKb2/e4WnLDLymiPgmvoEE65RucW33EfBW SR8/uMF8beDfL7E+T5PSoQvNUw+hKha4sw0dZ1pDZaDh8cmElor0VYsPw++xiDWEkJlT oiINo3ez194hPWWHAkEfuANGiAqsJJQimhDWYJjw/AV5+SA3Eo4vbVEME9gmy+jpycOV RRKjBm+tNLI+NMZssyuynkCmkFJjljlz3eM2eT7oW1o+bMQN0Si/ukjgcs8OZZ44C/Zd Dyuo4nna5KbqIi8oQ7c/vrpc6ds3VEAm25sd0i1CUNOW5KFkEzIPVR8m/FxNn9yy2NoR XYPg== X-Gm-Message-State: AHQUAuYehnMssu0r1vr1lpBX0CJheQX6MiwtaZNzAct0mp0u7aN22Q1Q K0AgffnouvveZ6a2a2C+sPt4eUPA X-Google-Smtp-Source: AHgI3IZaAbw2sdRpmb/oGvDNyXxZ9LB9T0nkLlvJfX3KxcVOSP++qesUFkoRgvk/zfIDkw9xmHDlKw== X-Received: by 2002:ac2:5230:: with SMTP id i16mr5109684lfl.63.1550227438135; Fri, 15 Feb 2019 02:43:58 -0800 (PST) Received: from ?IPv6:2001:6b0:1:1041:329:4029:1326:cfa0? ([2001:6b0:1:1041:329:4029:1326:cfa0]) by smtp.gmail.com with ESMTPSA id m24sm648708lje.13.2019.02.15.02.43.57 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 02:43:57 -0800 (PST) To: netdev@vger.kernel.org From: Elias Rydberg Subject: r8169 driver causing screen flickering since commit a99790bf5c7f3d68d8b01e015d3212a98ee7bd57 Message-ID: Date: Fri, 15 Feb 2019 11:44:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Since commit a99790bf5c7f3d68d8b01e015d3212a98ee7bd57, some systems have experienced screen flickering, followed by a black screen, when using WiFi (for example starting NetworkManager). So far this only seems to be a problem with the following spec: CPU: Intel i7-8550U WiFi module: Intel AC-9260 1730Mbps I contacted the author of the commit and got the following reply: "From platforms I’ve seen, if ASPM on r8169 is disabled, the deepest Package C-State on Intel CPU will limit to PC3. If the ASPM on r8169 is enabled, it can reach to PC8 when the display is on, and be able to reach PC10 when display is off. So the issue seems to be a platform bug - deeper Package C state makes your system unstable. Please contact the system vendor, the deepest Package C state can be reach should be set by BIOS." Now, Kai-Heng suggest contacting the system vendor, but after consulting my distributions forum, I got the suggestion of contacting this email list in hope of implementing a patch disabling the ASPM in the r8169 in systems with this spec. I apologize if this is a completely unreasonable request; I'm not experienced with kernel developing. Kind regards, Elias Rydberg Thread in my distributions forum, which includes more information: https://bbs.archlinux.org/viewtopic.php?id=244115 The result of a kernel bisection I did: |a99790bf5c7f3d68d8b01e015d3212a98ee7bd57 is the first bad commit commit a99790bf5c7f3d68d8b01e015d3212a98ee7bd57 Author: Kai-Heng Feng > Date: Thu Jun 21 16:30:39 2018 +0800 r8169: Reinstate ASPM Support On Intel platforms (Skylake and newer), ASPM support in r8169 is the last missing puzzle to let CPU's Package C-State reaches PC8. Without ASPM support, the CPU cannot reach beyond PC3. PC8 can save additional ~3W in comparison with PC3 on a Coffee Lake platform, Dell G3 3779. This is based on the work from Chunhao Lin >. Signed-off-by: Kai-Heng Feng > Signed-off-by: David S. Miller > :040000 040000 87d4515c14f8eb8cf99b6f47f97ca4db700931c1 e542595c74609136a7094777afb10b83012f6643 M drivers|