From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53814 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbeCPSPJ (ORCPT ); Fri, 16 Mar 2018 14:15:09 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2GIDTkJ033119 for ; Fri, 16 Mar 2018 14:15:09 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2grf45t3sj-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Fri, 16 Mar 2018 14:15:08 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Mar 2018 14:15:07 -0400 Subject: Re: [PATCH net-next v3 1/7] ibmvnic: Generalize TX pool structure To: David Miller Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com References: <1521129763-21030-1-git-send-email-tlfalcon@linux.vnet.ibm.com> <1521129763-21030-2-git-send-email-tlfalcon@linux.vnet.ibm.com> <20180316.125202.392278218093047323.davem@davemloft.net> From: Thomas Falcon Date: Fri, 16 Mar 2018 13:15:03 -0500 MIME-Version: 1.0 In-Reply-To: <20180316.125202.392278218093047323.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Message-Id: Sender: netdev-owner@vger.kernel.org List-ID: On 03/16/2018 11:52 AM, David Miller wrote: > From: Thomas Falcon > Date: Thu, 15 Mar 2018 11:02:37 -0500 > >> Remove some unused fields in the structure and include values >> describing the individual buffer size and number of buffers in >> a TX pool. This allows us to use these fields for TX pool buffer >> accounting as opposed to using hard coded values. Finally, split >> TSO buffers out and provide an additional TX pool array for TSO. >> >> Signed-off-by: Thomas Falcon > ... >> diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h >> index 099c89d..a2e21b3 100644 >> --- a/drivers/net/ethernet/ibm/ibmvnic.h >> +++ b/drivers/net/ethernet/ibm/ibmvnic.h >> @@ -917,11 +917,9 @@ struct ibmvnic_tx_pool { >> int *free_map; >> int consumer_index; >> int producer_index; >> - wait_queue_head_t ibmvnic_tx_comp_q; >> - struct task_struct *work_thread; >> struct ibmvnic_long_term_buff long_term_buff; >> - struct ibmvnic_long_term_buff tso_ltb; >> - int tso_index; >> + int num_buffers; >> + int buf_size; >> }; >> >> struct ibmvnic_rx_buff { > Thomas, members like tso_ltb are used in the code at this point. > > You can't remove it here like this, because it makes your patch series > non-bisectable. The tree should compile cleanly and work properly at > each stage of your series. > > Thank you. > Thanks for your review, I'll send a reworked series soon.