From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829781CD15 for ; Sat, 13 Dec 2025 22:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765663357; cv=none; b=exW+4ekzJFkY1qPIfb4CJTf1oi6B62nj0EBtE3qsq9n9qC6boDX12t30e8uFwghFajWzctAhzjrHq8Lf4FmEq3j3uEc6cSqZxmeG3TyXVp4+6j0oUhDYP5YA0o5JChCEhPBTDA0wD83EFMHB4Be7Ej4DafuKqWUuiDz4lgTS4Ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765663357; c=relaxed/simple; bh=QoogjRvJoA4lsuW7Esl/JJPzJ5Y/WKpughynwpUYoz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IqtCJOxgu9WBYDsQUkSOjqVp0+CBBWHLuOihk8eMNXcz7mP/ncZh6ekzWaS0jaQhNeOkL8+jafg0imUGpImpyB7+fdbuFmlQkPl/sujn0ZoNgfNgpR4nCVcfk0wjhd/5WagrwkmSNCSpmLOEnCHiFaWPqp7UGe0a9gsz1ojJsN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LC4vO/3U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LC4vO/3U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 854A8C4CEF7; Sat, 13 Dec 2025 22:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765663357; bh=QoogjRvJoA4lsuW7Esl/JJPzJ5Y/WKpughynwpUYoz8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LC4vO/3Ue4aDtHC7UHuLX8yNj4nXyp40CdFWp7fD7hdPRqrimEDzHNfCEHGfxFrHs SD9aBkxnJjwbLMEhmXVpHJoD9UgNpbbP0JMOhzYaQFyIHA83yEKA2bTctQlSvmP8Em p+d0rDtpr82vBckUkBRY91fNM/rH99n2RcWuXsOym9mU+lM47KU4Arz39YBl0lpdDJ IE6ZfkVuFmGTKIr/sb5hqNAwLvOFFpkN5R/qo5UrGGbeer7ZyEuq/dA3BNwcommBhO GvQ9QLP3JuLJpmp22PtV1mos4ye1VPgRK7XHOVfXr2AWR/Vct1eLMW8iTdTCmiqBG8 Luh/hTz055Xfw== Message-ID: Date: Sat, 13 Dec 2025 15:02:35 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 2/2] selftests: fib_nexthops: Add test case for ipv4 multi nexthops Content-Language: en-US To: Vadim Fedorenko , Willem de Bruijn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Willem de Bruijn , Jakub Kicinski Cc: Shuah Khan , Ido Schimmel , netdev@vger.kernel.org References: <20251213135849.2054677-1-vadim.fedorenko@linux.dev> <20251213135849.2054677-2-vadim.fedorenko@linux.dev> <8cd00280-08a0-457d-a7c6-a88670595ce8@linux.dev> From: David Ahern In-Reply-To: <8cd00280-08a0-457d-a7c6-a88670595ce8@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/13/25 2:26 PM, Vadim Fedorenko wrote: >> There is more going on than just not using the group feature. >> >> Would it make sense to split this into two test patches, a base test >> and a follow-on that extends with the loopback special case? > > Sounds reasonable, I'll split it in v2 > any test case for loopback needs another one with VRFs where the VRF device is the loopback for that domain.