* Compiler warning
@ 2019-02-04 11:43 Koen Vandeputte
2019-02-05 2:55 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Koen Vandeputte @ 2019-02-04 11:43 UTC (permalink / raw)
To: netdev
Hi All,
I'm seeing following compiler warning during kernel compilation
(5.0-rc5 and 4.14.96):
net/core/dev.c: In function 'validate_xmit_skb_list':
net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in
this function [-Wmaybe-uninitialized]
tail->next = skb;
~~~~~~~~~~~^~~~~
Source shows this:
https://elixir.bootlin.com/linux/v5.0-rc5/source/net/core/dev.c#L3387
Looks like "tail" can get deferenced while it indeed doesn't get
initialized? Kind regards, Koen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Compiler warning
2019-02-04 11:43 Compiler warning Koen Vandeputte
@ 2019-02-05 2:55 ` David Ahern
2019-02-07 13:55 ` Koen Vandeputte
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2019-02-05 2:55 UTC (permalink / raw)
To: Koen Vandeputte, netdev
On 2/4/19 3:43 AM, Koen Vandeputte wrote:
> Hi All,
>
> I'm seeing following compiler warning during kernel compilation
> (5.0-rc5 and 4.14.96):
>
>
> net/core/dev.c: In function 'validate_xmit_skb_list':
> net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> tail->next = skb;
> ~~~~~~~~~~~^~~~~
>
>
> Source shows this:
>
> https://elixir.bootlin.com/linux/v5.0-rc5/source/net/core/dev.c#L3387
>
> Looks like "tail" can get deferenced while it indeed doesn't get
> initialized? Kind regards, Koen
>
same with this one - false positive. head is initialized to NULL. tail
is set on the first pass through the loop.
What compiler / version is this?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Compiler warning
2019-02-05 2:55 ` David Ahern
@ 2019-02-07 13:55 ` Koen Vandeputte
0 siblings, 0 replies; 3+ messages in thread
From: Koen Vandeputte @ 2019-02-07 13:55 UTC (permalink / raw)
To: David Ahern, netdev
On 05.02.19 03:55, David Ahern wrote:
> On 2/4/19 3:43 AM, Koen Vandeputte wrote:
>> Hi All,
>>
>> I'm seeing following compiler warning during kernel compilation
>> (5.0-rc5 and 4.14.96):
>>
>>
>> net/core/dev.c: In function 'validate_xmit_skb_list':
>> net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in
>> this function [-Wmaybe-uninitialized]
>> tail->next = skb;
>> ~~~~~~~~~~~^~~~~
>>
>>
>> Source shows this:
>>
>> https://elixir.bootlin.com/linux/v5.0-rc5/source/net/core/dev.c#L3387
>>
>> Looks like "tail" can get deferenced while it indeed doesn't get
>> initialized? Kind regards, Koen
>>
> same with this one - false positive. head is initialized to NULL. tail
> is set on the first pass through the loop.
>
> What compiler / version is this?
Thanks for confirming David. (for both of the warnings)
This is seen using GCC 7.4.0
I don't know the policy upstream regarding compiler warnings .. so
thought I should report these. :)
Regards,
Koen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-07 13:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-04 11:43 Compiler warning Koen Vandeputte
2019-02-05 2:55 ` David Ahern
2019-02-07 13:55 ` Koen Vandeputte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).