Re: [net, 6/6] net: korina: version bump

Felix Fietkau
2017-01-22T13:21:49Z

On 2017-01-22 13:10, Roman Yeryomin wrote:
> On 17 January 2017 at 21:19, Roman Yeryomin <leroi.lists@gmail.com> wrote:
>> On 17 January 2017 at 20:55, Felix Fietkau <nbd@nbd.name> wrote:
>>> On 2017-01-17 18:33, Roman Yeryomin wrote:
>>>> Signed-off-by: Roman Yeryomin <roman@advem.lv>
>>>> ---
>>>> drivers/net/ethernet/korina.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
>>>> index 83c994f..c8fed01 100644
>>>> --- a/drivers/net/ethernet/korina.c
>>>> +++ b/drivers/net/ethernet/korina.c
>>>> @@ -66,8 +66,8 @@
>>>> #include <asm/mach-rc32434/dma_v.h>
>>>>
>>>> #define DRV_NAME "korina"
>>>> -#define DRV_VERSION "0.10"
>>>> -#define DRV_RELDATE "04Mar2008"
>>>> +#define DRV_VERSION "0.20"
>>>> +#define DRV_RELDATE "15Jan2017"
>>> I think it would make more sense to remove this version instead of
>>> bumping it. Individual driver versions are rather pointless, the kernel
>>> version is more meaningful anyway.
>>
>> OK, makes sense
>
> Actually, after thinking a bit more about this, not really...
> How about ethtool, which uses driver name and version?
> I see most ethernet drivers define some version. And it's pretty
> useful, when using backports.
> IMO, it should be kept and bumped.
I don't really care, I just wanted to point out that the exact kernel
version is a much more useful indicator, especially since not all patch
submitters do the useless version bump dance.

- Felix