Re: [EXTERNAL] Re: [PATCH net-next] net: marvell: prestera: fix FEC error message for SFP ports

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

On 2/5/2026 7:57 AM, Jakub Kicinski wrote:
> On Wed, 4 Feb 2026 13:13:31 +0000 Elad Nachman wrote:
>>>> I'm pretty sure that the condition here is wrong, not the error message.
>>>>
>>>> AFAIK it doesn't make sense to configure FEC on ethernet/copper ports,
>>>> but for SFP ports, it may be required depending on the transceiver or
>>>> cable used, especially for fiber modules.
>>>>
>>>> I may be wrong though.
>>>>
>>>> This check was introduced with bb5dbf2cc64d ("net: marvell: prestera:
>>>> add firmware v4.0 support"), but that commit does not offer any
>>>> explanation for it in the commit message.
>>>
>>> Elad, could you clarify this? A bit hard to tell whether CR is included
>>> in "SFP" from glancing at the code.
>>
>> Basically, the supported devices have FEC on 10G-BASE-KR and upwards
>> (CR: from 40G-BASE-CR), and for USXGMII SERDES, which drives multiple
>> copper PHYs.
>>
>> Judging based on all of the above,
>> I think it is best to remove this check (plus said error message)
>> altogether and let the firmware return an error if the mode/speed/FEC
>> combination is invalid.
> 
> SG, thanks for explaining
> 
> Alok, pls respin as suggested.

Thanks for the clarification.
I will send a v2 that removes the "port->caps.transceiver == 
PRESTERA_PORT_TCVR_SFP"
check and lets the firmware handle validation.

Thanks,
Alok