From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [RFC iproute2-next 00/16] iproute printing enhancements
Date: Thu, 1 Feb 2018 20:08:37 -0700
Message-ID: <e61c4737-4ca0-c4da-0530-e50cfa414370@gmail.com>
References: <20180202011946.21929-1-sthemmin@microsoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f45.google.com ([209.85.160.45]:43665 "EHLO
        mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751561AbeBBDIj (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 1 Feb 2018 22:08:39 -0500
Received: by mail-pl0-f45.google.com with SMTP id f4so5114064plr.10
        for <netdev@vger.kernel.org>; Thu, 01 Feb 2018 19:08:39 -0800 (PST)
In-Reply-To: <20180202011946.21929-1-sthemmin@microsoft.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2/1/18 6:19 PM, Stephen Hemminger wrote:
> The first group of patches refactor the printout to breakup
> excessively long print_route function and the last few implement
> JSON and color output format for routes.
> 
> The one thing that maybe controversial is changing the default
> json output format to be compact. The value of JSON is for programattic
> output therefore pretty-printing should be an option.
> 
> One change I didn't make (but considered) is not calling fflush
> after every single entry. When dumping millions of routes, letting
> stdio buffer output would be a performance win.
> 
> Stephen Hemminger (16):
>   iproute: refactor printing flags
>   iproute: make printing icmpv6 a function
>   iproute: make printing IPv4 cache flags a function
>   iproute: refactor cacheinfo printing
>   iproute: refactor metrics print
>   iproute: refactor printing flow info
>   iproute2: refactor newdst, gateway and via printing
>   iproute: refactor multipath print
>   iproute: refactor printing of interface
>   iproute: whitespace fixes
>   iproute: don't do assignment in condition
>   iproute: make flush a separate function
>   iproute: implement JSON and color output
>   json: make pretty printing optional
>   man: add documentation for json and pretty flags
>   json: fix newline at end of array
> 

The first 12 look fine to me; familiar territory. Why not send those
outside of the json patches which require a closer look?