From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirill Tkhai Subject: Re: [BUG/Q] can_pernet_exit() leaves devices on dead net Date: Mon, 2 Apr 2018 18:36:44 +0300 Message-ID: References: <8c941b2d-0c90-ba6c-6020-23530b146fd9@virtuozzo.com> <38145688-1c15-3df4-c127-591959a759ff@hartkopp.net> <21bafe4a-984f-2897-b092-270ccda136f0@virtuozzo.com> <9f3585bb-4cf9-b0e1-3069-37fbae2ce54b@hartkopp.net> <377fbd8a-cd7e-2650-8efd-907cea0a0aee@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, dev@kicherer.org To: Oliver Hartkopp , mkl@pengutronix.de Return-path: Received: from mail-db5eur01on0136.outbound.protection.outlook.com ([104.47.2.136]:39857 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751443AbeDBPgu (ORCPT ); Mon, 2 Apr 2018 11:36:50 -0400 In-Reply-To: <377fbd8a-cd7e-2650-8efd-907cea0a0aee@hartkopp.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi, Oliver, On 02.04.2018 18:28, Oliver Hartkopp wrote: > Hi Kirill, Marc, > > I checked the code once more and added some debug output to the other parts in CAN notifier code. > > In fact the code pointed to by both of you seems to be obsolete as I only wanted to be 'really sure' that no leftovers of the CAN filters at module unloading. > > >> Yes, this one looks good: >> https://marc.info/?l=linux-can&m=150169589119335&w=2 >> >> Regards, >> Kirill >> > > I was obviously too cautious ;-) > > All tests I made resulted in the function iterating through all the CAN netdevices doing exactly nothing. > > I'm fine with removing that stuff - but I'm not sure whether it's worth to push that patch to stable 4.12+ or even before 4.12 (without namespace support - and removing rcu_barrier() too). > > Any opinions? I think the same -- it's not need for stable as there is just iteration over empty list, i.e., noop. Kirill