From: "Arinzon, David" <darinzon@amazon.com>
To: Vadim Fedorenko <vadfed@meta.com>,
Maciek Machnikowski <maciek@machnikowski.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"jacob.e.keller@intel.com" <jacob.e.keller@intel.com>,
"Bernstein, Amit" <amitbern@amazon.com>
Subject: RE: [RFC 0/3] ptp: Add esterror support
Date: Thu, 15 Aug 2024 11:40:37 +0000 [thread overview]
Message-ID: <e61e087d636c44cba4aa94cc414e921c@amazon.com> (raw)
In-Reply-To: <9a15379e-9c1e-4778-bda1-38474a8d9317@meta.com>
> >
> >
> > On 15/08/2024 02:41, Jakub Kicinski wrote:
> >> On Tue, 13 Aug 2024 12:55:59 +0000 Maciek Machnikowski wrote:
> >>> This patch series implements handling of timex esterror field by ptp
> >>> devices.
> >>>
> >>> Esterror field can be used to return or set the estimated error of
> >>> the clock. This is useful for devices containing a hardware clock
> >>> that is controlled and synchronized internally (such as a time card)
> >>> or when the synchronization is pushed to the embedded CPU of a DPU.
> >>>
> >>> Current implementation of ADJ_ESTERROR can enable pushing current
> >>> offset of the clock calculated by a userspace app to the device,
> >>> which can act upon this information by enabling or disabling
> >>> time-related functions when certain boundaries are not met (eg.
> >>> packet launchtime)
> >>
> >> Please do CC people who are working on the VM / PTP / vdso thing, and
> >> time people like tglx. And an implementation for a real device would
> >> be nice to establish attention.
> >
> > Noted - will CC in future releases.
> >
> > AWS planned the implementation in ENA driver - will work with David on
> > making it part of the patchset once we "upgrade" from an RFC - but
> > wanted to discuss the approach first.
>
> I can implement the interface for OCP TimeCard too, I think we have HW
> information about it already.
CC Amit Bernstein (AWS, ENA driver).
prev parent reply other threads:[~2024-08-15 11:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 12:55 [RFC 0/3] ptp: Add esterror support Maciek Machnikowski
2024-08-13 12:56 ` [RFC 1/3] ptp: Implement timex " Maciek Machnikowski
2024-08-14 9:29 ` Vadim Fedorenko
2024-08-15 9:33 ` Maciek Machnikowski
2024-08-14 11:46 ` Simon Horman
2024-08-15 9:32 ` Maciek Machnikowski
2024-08-15 4:23 ` Richard Cochran
2024-08-15 9:43 ` Maciek Machnikowski
2024-08-15 9:47 ` Maciek Machnikowski
2024-08-15 21:04 ` Richard Cochran
2024-08-13 12:56 ` [RFC 2/3] ptp: Implement support for esterror in ptp_mock Maciek Machnikowski
2024-08-13 12:56 ` [RFC 3/3] ptp: Add setting esterror and reading timex structure Maciek Machnikowski
2024-08-13 20:05 ` [RFC 0/3] ptp: Add esterror support Andrew Lunn
2024-08-14 8:44 ` Vadim Fedorenko
2024-08-14 13:08 ` Andrew Lunn
2024-08-14 15:08 ` Maciek Machnikowski
2024-08-15 3:53 ` Richard Cochran
2024-08-15 9:40 ` Maciek Machnikowski
2024-08-15 14:26 ` Andrew Lunn
2024-08-15 15:00 ` Maciek Machnikowski
2024-08-15 21:08 ` Richard Cochran
2024-08-15 22:06 ` Maciek Machnikowski
2024-08-15 23:11 ` Andrew Lunn
2024-08-16 4:13 ` Maciek Machnikowski
2024-08-17 4:29 ` Richard Cochran
2024-08-15 3:33 ` Richard Cochran
2024-08-15 4:16 ` Richard Cochran
2024-08-15 5:24 ` Miroslav Lichvar
2024-08-15 9:45 ` Maciek Machnikowski
2024-08-15 9:41 ` Maciek Machnikowski
2024-08-15 0:41 ` Jakub Kicinski
2024-08-15 3:42 ` Richard Cochran
2024-08-15 4:17 ` Richard Cochran
2024-08-15 9:35 ` Maciek Machnikowski
2024-08-15 10:29 ` Vadim Fedorenko
2024-08-15 11:40 ` Arinzon, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e61e087d636c44cba4aa94cc414e921c@amazon.com \
--to=darinzon@amazon.com \
--cc=amitbern@amazon.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=maciek@machnikowski.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadfed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).