From: Florian Fainelli <f.fainelli@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example
Date: Sat, 3 Oct 2020 08:56:32 -0700 [thread overview]
Message-ID: <e62b8072-ab7a-ce6d-1ac1-7fcb1b28081d@gmail.com> (raw)
In-Reply-To: <20201003093051.7242-2-kurt@linutronix.de>
On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote:
> There is no such property as duplex-full. It's called full-duplex. Leading to
> reduced speed when using the example as base for a real device tree.
Doh, thanks for correcting this. Would you want to make this a YAML
binding at some point? I can take care of it if you do not have time to
do it.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-10-03 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 9:30 [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex Kurt Kanzenbach
2020-10-03 9:30 ` [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example Kurt Kanzenbach
2020-10-03 15:56 ` Florian Fainelli [this message]
2020-10-04 11:00 ` Kurt Kanzenbach
2020-10-04 0:35 ` David Miller
2020-10-03 15:55 ` [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex Florian Fainelli
2020-10-04 0:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e62b8072-ab7a-ce6d-1ac1-7fcb1b28081d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).