From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
borkmann@iogearbox.net, ast@kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [bpf-next PATCH v2 3/7] bpf: sockmap sample, use fork() for send and recv
Date: Thu, 11 Jan 2018 20:33:21 -0800 [thread overview]
Message-ID: <e6381904-cb93-2d22-a487-1c3d0872046a@gmail.com> (raw)
In-Reply-To: <cbaf8a23-e446-3831-78c2-c8ad9aeb52a0@iogearbox.net>
On 01/10/2018 05:31 PM, Daniel Borkmann wrote:
> On 01/10/2018 07:39 PM, John Fastabend wrote:
>> Currently for SENDMSG tests first send completes then recv runs. This
>> does not work well for large data sizes and/or many iterations. So
>> fork the recv and send handler so that we run both send and recv. In
>> the future we can add a parameter to do more than a single fork of
>> tx/rx.
>>
>> With this we can get many GBps of data which helps exercise the
>> sockmap code.
>>
>> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
>> ---
>> samples/sockmap/Makefile | 2 +
>> samples/sockmap/sockmap_user.c | 58 +++++++++++++++++++++++++++++-----------
>> 2 files changed, 43 insertions(+), 17 deletions(-)
>>
>> diff --git a/samples/sockmap/Makefile b/samples/sockmap/Makefile
>> index 73f1da4..4fefd66 100644
>> --- a/samples/sockmap/Makefile
>> +++ b/samples/sockmap/Makefile
>> @@ -8,7 +8,7 @@ HOSTCFLAGS += -I$(objtree)/usr/include
>> HOSTCFLAGS += -I$(srctree)/tools/lib/
>> HOSTCFLAGS += -I$(srctree)/tools/testing/selftests/bpf/
>> HOSTCFLAGS += -I$(srctree)/tools/lib/ -I$(srctree)/tools/include
>> -HOSTCFLAGS += -I$(srctree)/tools/perf
>> +HOSTCFLAGS += -I$(srctree)/tools/perf -g
>
> Slipped in here?
>
Yep, removed in v3. Thanks.
>> sockmap-objs := ../bpf/bpf_load.o $(LIBBPF) sockmap_user.o
>>
>> diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c
>> index 2d51672..48fa09a 100644
>> --- a/samples/sockmap/sockmap_user.c
>> +++ b/samples/sockmap/sockmap_user.c
>> @@ -23,6 +23,7 @@
>> #include <stdbool.h>
>> #include <signal.h>
>> #include <fcntl.h>
>> +#include <sys/wait.h>
> [...]
>
next prev parent reply other threads:[~2018-01-12 4:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 18:38 [bpf-next PATCH v2 0/7] sockmap sample update John Fastabend
2018-01-10 18:39 ` [bpf-next PATCH v2 1/7] bpf: refactor sockmap sample program update for arg parsing John Fastabend
2018-01-11 1:25 ` Daniel Borkmann
2018-01-12 4:31 ` John Fastabend
2018-01-12 4:58 ` John Fastabend
2018-01-11 21:05 ` Martin KaFai Lau
2018-01-12 3:54 ` John Fastabend
2018-01-10 18:39 ` [bpf-next PATCH v2 2/7] bpf: add sendmsg option for testing BPF programs John Fastabend
2018-01-11 1:28 ` Daniel Borkmann
2018-01-11 21:08 ` Martin KaFai Lau
2018-01-10 18:39 ` [bpf-next PATCH v2 3/7] bpf: sockmap sample, use fork() for send and recv John Fastabend
2018-01-11 1:31 ` Daniel Borkmann
2018-01-12 4:33 ` John Fastabend [this message]
2018-01-11 21:08 ` Martin KaFai Lau
2018-01-12 3:57 ` John Fastabend
2018-01-10 18:39 ` [bpf-next PATCH v2 4/7] bpf: sockmap sample, report bytes/sec John Fastabend
2018-01-10 18:40 ` [bpf-next PATCH v2 5/7] bpf: sockmap sample add base test without any BPF for comparison John Fastabend
2018-01-11 21:10 ` Martin KaFai Lau
2018-01-12 4:03 ` John Fastabend
2018-01-10 18:40 ` [bpf-next PATCH v2 6/7] bpf: sockmap put client sockets in blocking mode John Fastabend
2018-01-10 18:40 ` [bpf-next PATCH v2 7/7] bpf: sockmap set rlimit John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6381904-cb93-2d22-a487-1c3d0872046a@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).