From: Sean Anderson <sean.anderson@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>, Suraj Gupta <suraj.gupta2@amd.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
radhey.shyam.pandey@amd.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
michal.simek@amd.com, linux@armlinux.org.uk,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bmasney@redhat.com
Subject: Re: [PATCH 2/2] net: axienet: Fix resource release ordering
Date: Mon, 12 Jan 2026 09:53:28 -0500 [thread overview]
Message-ID: <e6499ec9-92d3-4a63-8172-3c09a8b64066@linux.dev> (raw)
In-Reply-To: <20260110115306.4049b2cb@kernel.org>
On 1/10/26 14:53, Jakub Kicinski wrote:
> On Fri, 9 Jan 2026 12:40:51 +0530 Suraj Gupta wrote:
>> Device-managed resources are released after manually-managed resources.
>> Therefore, once any manually-managed resource is acquired, all further
>> resources must be manually-managed too.
>
> only for resources which have dependencies. Please include in the commit
> message what exactly is going wrong in this driver. The commit under
> Fixes seems to be running ioremap, I don't see how that matters vs
> netdev allocation for example..
In the series I originally submitted this in, I wanted to add a devm
resources (mdio bus etc.) at the end of probe that required the clocks
to be running. But as a standalone patch this is more of a cleanup.
>> Convert all resources before the MDIO bus is created into device-managed
>> resources. In all cases but one there are already devm variants available.
next prev parent reply other threads:[~2026-01-12 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 7:10 [PATCH 0/2] Add devm_clk_bulk_get_optional_enable() helper and use in AXI Ethernet driver Suraj Gupta
2026-01-09 7:10 ` [PATCH 1/2] clk: Add devm_clk_bulk_get_optional_enable() helper Suraj Gupta
2026-01-09 7:10 ` [PATCH 2/2] net: axienet: Fix resource release ordering Suraj Gupta
2026-01-10 19:53 ` Jakub Kicinski
2026-01-12 14:53 ` Sean Anderson [this message]
2026-01-13 5:32 ` Gupta, Suraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6499ec9-92d3-4a63-8172-3c09a8b64066@linux.dev \
--to=sean.anderson@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=bmasney@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sboyd@kernel.org \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox