From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net_sched: blackhole: tell upper qdisc about dropped
 packets
Date: Fri, 15 Jun 2018 06:13:05 -0700
Message-ID: <e654c245-7745-f49a-c995-7071e0e57153@gmail.com>
References: <152905845136.88583.6197221349040585517.stgit@buzz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Jamal Hadi Salim <jhs@mojatatu.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:39533 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933771AbeFONNI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 15 Jun 2018 09:13:08 -0400
Received: by mail-pl0-f65.google.com with SMTP id f1-v6so5350652plt.6
        for <netdev@vger.kernel.org>; Fri, 15 Jun 2018 06:13:07 -0700 (PDT)
In-Reply-To: <152905845136.88583.6197221349040585517.stgit@buzz>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/15/2018 03:27 AM, Konstantin Khlebnikov wrote:
> When blackhole is used on top of classful qdisc like hfsc it breaks
> qlen and backlog counters because packets are disappear without notice.
> 
> In HFSC non-zero qlen while all classes are inactive triggers warning:
> WARNING: ... at net/sched/sch_hfsc.c:1393 hfsc_dequeue+0xba4/0xe90 [sch_hfsc]
> and schedules watchdog work endlessly.
> 
> This patch return __NET_XMIT_BYPASS in addition to NET_XMIT_SUCCESS,
> this flag tells upper layer: this packet is gone and isn't queued.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
>  net/sched/sch_blackhole.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sched/sch_blackhole.c b/net/sched/sch_blackhole.c
> index c98a61e980ba..9c4c2bb547d7 100644
> --- a/net/sched/sch_blackhole.c
> +++ b/net/sched/sch_blackhole.c
> @@ -21,7 +21,7 @@ static int blackhole_enqueue(struct sk_buff *skb, struct Qdisc *sch,
>  			     struct sk_buff **to_free)
>  {
>  	qdisc_drop(skb, sch, to_free);
> -	return NET_XMIT_SUCCESS;
> +	return NET_XMIT_SUCCESS | __NET_XMIT_BYPASS;

Why do not we use instead :

	return qdisc_drop(skb, sch, to_free);

Although noop_enqueue() seems to use :

	return NET_XMIT_CN;

Oh well.