From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH] r8169: Fix netpoll oops Date: Wed, 20 Jun 2018 20:51:23 +0200 Message-ID: References: <20180620120153.11676-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Realtek linux nic maintainers , "David S . Miller" To: Ville Syrjala , netdev@vger.kernel.org Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:51708 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbeFTSva (ORCPT ); Wed, 20 Jun 2018 14:51:30 -0400 Received: by mail-wm0-f66.google.com with SMTP id r15-v6so1166902wmc.1 for ; Wed, 20 Jun 2018 11:51:30 -0700 (PDT) In-Reply-To: <20180620120153.11676-1-ville.syrjala@linux.intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 20.06.2018 14:01, Ville Syrjala wrote: > From: Ville Syrjälä > > Pass the correct thing to rtl8169_interrupt() from netpoll. > Indeed, this place I missed to change. Only small remark: The patch should be annotated as "net" so that it can go to 4.18. > Cc: Realtek linux nic maintainers > Cc: netdev@vger.kernel.org > Cc: Heiner Kallweit > Cc: David S. Miller > Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type") > Signed-off-by: Ville Syrjälä > --- > drivers/net/ethernet/realtek/r8169.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index 75dfac0248f4..f4cae2be0fda 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7148,7 +7148,7 @@ static void rtl8169_netpoll(struct net_device *dev) > { > struct rtl8169_private *tp = netdev_priv(dev); > > - rtl8169_interrupt(pci_irq_vector(tp->pci_dev, 0), dev); > + rtl8169_interrupt(pci_irq_vector(tp->pci_dev, 0), tp); > } > #endif > >