From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A8ACC43603 for ; Wed, 11 Dec 2019 13:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AC822464B for ; Wed, 11 Dec 2019 13:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FfJgOOlu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729541AbfLKNUL (ORCPT ); Wed, 11 Dec 2019 08:20:11 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:39256 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729415AbfLKNUL (ORCPT ); Wed, 11 Dec 2019 08:20:11 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id xBBDK4vN099616; Wed, 11 Dec 2019 07:20:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1576070404; bh=GkhHaPX9UDNVUYDu93wWRNflhV/Vz2l5vZp7YzYxuYQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=FfJgOOluYkKqpDli4kXsWHirurmSnFSzU8sydhPy+xpmaZt/61syyf/wC8IouSpQR emEEdpzQmC4uNwvnPqhB6B9qU3grWeB47hzosPAHAc3uwD1yPft1CvTqKp3xKKcmbu sWmkbwaqS1j4gbYX0/OusjQWUgkgHseWp9H455wM= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xBBDK4sE085099 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Dec 2019 07:20:04 -0600 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 11 Dec 2019 07:20:04 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 11 Dec 2019 07:20:04 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id xBBDK2lH040964; Wed, 11 Dec 2019 07:20:02 -0600 Subject: Re: [PATCH 2/2] net: ethernet: ti: build cpsw-common for switchdev To: Arnd Bergmann , "David S. Miller" CC: Ilias Apalodimas , Murali Karicheri , Andrew Lunn , , References: <20191211125643.1987157-1-arnd@arndb.de> <20191211125643.1987157-2-arnd@arndb.de> From: Grygorii Strashko Message-ID: Date: Wed, 11 Dec 2019 15:19:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191211125643.1987157-2-arnd@arndb.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/12/2019 14:56, Arnd Bergmann wrote: > Without the common part of the driver, the new file fails to link: > > drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_probe': > cpsw_new.c:(.text+0x312c): undefined reference to `ti_cm_get_macid' > > Use the same Makefile hack as before, and build cpsw-common.o for > any driver that needs it. > > Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ethernet/ti/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/ti/Makefile b/drivers/net/ethernet/ti/Makefile > index d34df8e5cf94..ecf776ad8689 100644 > --- a/drivers/net/ethernet/ti/Makefile > +++ b/drivers/net/ethernet/ti/Makefile > @@ -5,6 +5,7 @@ > > obj-$(CONFIG_TI_CPSW) += cpsw-common.o > obj-$(CONFIG_TI_DAVINCI_EMAC) += cpsw-common.o > +obj-$(CONFIG_TI_CPSW_SWITCHDEV) += cpsw-common.o > > obj-$(CONFIG_TLAN) += tlan.o > obj-$(CONFIG_CPMAC) += cpmac.o > Reviewed-by: Grygorii Strashko -- Best regards, grygorii