From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E706C18C011 for ; Thu, 29 Aug 2024 21:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724966661; cv=none; b=DWGlYNwfCTZw0zRhTY7X269W/bdSCMrmH2zU1wYmLs74b31e/cmlrwWuQKI++8yXXY9JgBflOaDk4wYV/TyhspP189uwVDNvy5WkFZITG4/52xxJhVJhwJHvezZ7U9S859j1/V/cuO8KCCkve2VTEi+8kVDUVFSWLASnw1oGaLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724966661; c=relaxed/simple; bh=ZTznvASfFyaJB8TPJulZAiYKarZs1XBnRNJV9FDZ/rU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dIDGO9wPPIKIJsUQ1nyv2kG1isGShSCyisFA5OTBvSccnob44oJ+Z6vKHzYyicEuEJXJVfQxn88OLOnJn5VJaSSpOViYtR0XL/GPAMJGOj12GHuXVrZJEzxZAXfm2ehB34NoaXcnucDaH7/86YYSFb0ntmTdr4rhJ7h0Ba02hZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TKe8r0Ga; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TKe8r0Ga" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724966657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXzjPjLS9vSVhsheI8WtbPpu/8U+OSffQlIVe+EG86A=; b=TKe8r0GajpLht0y3E/oq1UJJcmT220gibuXdKOqzgNPeFwzTlTX8KyGPUYQqWzAxC3H89F GQ337Bnmi6ZEz683zi/hPWc2cFhklI2JgOvGZPaTCrUhoF0OOE9zrbTINrZGoy7/Y9+7g+ K2qioWgXl7nKeKdU+RNAiJbSsdFIJ5M= Date: Thu, 29 Aug 2024 22:24:07 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v23 03/13] netdev: support binding dma-buf to netdevice To: Jakub Kicinski , Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Willem de Bruijn , Kaiyuan Zhang , Daniel Vetter References: <20240829060126.2792671-1-almasrymina@google.com> <20240829060126.2792671-4-almasrymina@google.com> <20240829140824.555d016c@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20240829140824.555d016c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 29/08/2024 22:08, Jakub Kicinski wrote: > On Thu, 29 Aug 2024 06:01:16 +0000 Mina Almasry wrote: >> + err = genlmsg_reply(rsp, info); >> + if (err) >> + goto err_unbind; >> + >> return 0; >> + >> +err_unbind: > > rtnl_lock() There are 2 places with goto err_unbind, and one is under the lock, additional label (or rearrange of the last check) is needed.. >> + net_devmem_unbind_dmabuf(binding); >> +err_unlock: >> + rtnl_unlock();