Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Ren Wei <n05ec@lzu.edu.cn>, netdev@vger.kernel.org
Cc: edumazet@google.com, ncardwell@google.com, kuniyu@google.com,
	davem@davemloft.net, horms@kernel.org,
	chia-yu.chang@nokia-bell-labs.com, ij@kernel.org,
	idosch@nvidia.com, fmancera@suse.de,
	bronzed_45_vested@icloud.com, yuuchihsu@gmail.com,
	yuantan098@gmail.com, yifanwucs@gmail.com,
	tomapufckgml@gmail.com, bird@lzu.edu.cn, roxy520tt@gmail.com
Subject: Re: [PATCH net v3 1/1] tcp: bound SYN-ACK timers to reqsk timeout range
Date: Thu, 9 Jul 2026 12:13:16 +0200	[thread overview]
Message-ID: <e733f981-5856-425a-8b74-3f54d9086d57@redhat.com> (raw)
In-Reply-To: <20260702095324.2995243-1-n05ec@lzu.edu.cn>

On 7/2/26 11:52 AM, Ren Wei wrote:
> @@ -1034,6 +1035,7 @@ static struct ctl_table ipv4_net_table[] = {
>  		.maxlen		= sizeof(u8),
>  		.mode		= 0644,
>  		.proc_handler	= proc_dou8vec_minmax,
> +		.extra2		= &tcp_synack_retries_max

This new restriction, even if correct, may break existing scripts.

Since the rest of the patch enforces the upper bound at every
sysctl_tcp_synack_retries usage, what about dropping this chunk?

/P


      reply	other threads:[~2026-07-09 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  9:52 [PATCH net v3 1/1] tcp: bound SYN-ACK timers to reqsk timeout range Ren Wei
2026-07-09 10:13 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e733f981-5856-425a-8b74-3f54d9086d57@redhat.com \
    --to=pabeni@redhat.com \
    --cc=bird@lzu.edu.cn \
    --cc=bronzed_45_vested@icloud.com \
    --cc=chia-yu.chang@nokia-bell-labs.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=ij@kernel.org \
    --cc=kuniyu@google.com \
    --cc=n05ec@lzu.edu.cn \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=roxy520tt@gmail.com \
    --cc=tomapufckgml@gmail.com \
    --cc=yifanwucs@gmail.com \
    --cc=yuantan098@gmail.com \
    --cc=yuuchihsu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox