From: Florian Fainelli <f.fainelli@gmail.com>
To: Colin Foster <colin.foster@in-advantage.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Richard Cochran <richardcochran@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
UNGLinuxDriver@microchip.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH v2 net-next] net: mscc: ocelot: un-export unused regmap symbols
Date: Mon, 6 Feb 2023 10:31:37 -0800 [thread overview]
Message-ID: <e75577bb-df33-b0dd-42d9-a34e5d65887a@gmail.com> (raw)
In-Reply-To: <20230204182056.25502-1-colin.foster@in-advantage.com>
On 2/4/23 10:20, Colin Foster wrote:
> There are no external users of the vsc7514_*_regmap[] symbols or
> vsc7514_vcap_* functions. They were exported in commit 32ecd22ba60b ("net:
> mscc: ocelot: split register definitions to a separate file") with the
> intention of being used, but the actual structure used in commit
> 2efaca411c96 ("net: mscc: ocelot: expose vsc7514_regmap definition") ended
> up being all that was needed.
>
> Bury these unnecessary symbols.
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-02-06 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 18:20 [PATCH v2 net-next] net: mscc: ocelot: un-export unused regmap symbols Colin Foster
2023-02-06 0:01 ` Vladimir Oltean
2023-02-06 18:31 ` Florian Fainelli [this message]
2023-02-07 6:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e75577bb-df33-b0dd-42d9-a34e5d65887a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).