From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jon Maloy <jon.maloy@ericsson.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
"ying.xue@windriver.com" <ying.xue@windriver.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"tipc-discussion@lists.sourceforge.net"
<tipc-discussion@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tipc: ensure skb->lock is initialised
Date: Wed, 10 Jul 2019 10:00:28 +0200 [thread overview]
Message-ID: <e7606e76-8a0a-dab7-4561-f44f98d90164@gmail.com> (raw)
In-Reply-To: <MN2PR15MB35813EA3ADE7E5E83A657D3F9AF10@MN2PR15MB3581.namprd15.prod.outlook.com>
On 7/9/19 10:15 PM, Jon Maloy wrote:
>
> It is not only for lockdep purposes, -it is essential. But please provide details about where you see that more fixes are needed.
>
Simple fact that you detect a problem only when skb_queue_purge() is called should talk by itself.
As I stated, there are many places where the list is manipulated _without_ its spinlock being held.
You want consistency, then
- grab the spinlock all the time.
- Or do not ever use it.
Do not initialize the spinlock just in case a path will use skb_queue_purge() (instead of using __skb_queue_purge())
next prev parent reply other threads:[~2019-07-10 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 22:53 [PATCH] tipc: ensure skb->lock is initialised Chris Packham
2019-07-08 8:18 ` Eric Dumazet
2019-07-08 20:43 ` Chris Packham
2019-07-08 21:13 ` Chris Packham
2019-07-09 7:30 ` Eric Dumazet
2019-07-09 13:25 ` Jon Maloy
2019-07-09 13:45 ` Eric Dumazet
2019-07-09 20:15 ` Jon Maloy
2019-07-10 8:00 ` Eric Dumazet [this message]
2019-07-10 13:10 ` Jon Maloy
2019-07-10 20:58 ` Chris Packham
2019-07-11 12:55 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7606e76-8a0a-dab7-4561-f44f98d90164@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).