From: Andrew Lunn <andrew@lunn.ch>
To: Jakob Unterwurzacher <jakobunt@gmail.com>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
quentin.schulz@cherry.de,
Jakob Unterwurzacher <jakob.unterwurzacher@cherry.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
George McCollister <george.mccollister@gmail.com>
Subject: Re: [PATCH] net: dsa: microchip: linearize skb for tail-tagging switches
Date: Fri, 9 May 2025 14:31:00 +0200 [thread overview]
Message-ID: <e76f230c-a513-4185-ae3f-72c033aeeb1e@lunn.ch> (raw)
In-Reply-To: <20250509071820.4100022-1-jakob.unterwurzacher@cherry.de>
On Fri, May 09, 2025 at 09:18:19AM +0200, Jakob Unterwurzacher wrote:
> The pointer arithmentic for accessing the tail tag does not
> seem to handle nonlinear skbs.
>
> For nonlinear skbs, it reads uninitialized memory inside the
> skb headroom, essentially randomizing the tag, breaking user
> traffic.
Both tag_rtl8_4.c & tag_trailer.c also linearize, so i would say this
is correct.
What is interesting is that both xrs700x_rcv() and
sja1110_rcv_inband_control_extension() also don't call
skb_linearize().
Vladimir? George?
> Tested on v6.12.19 and today's master (d76bb1ebb5587f66b).
Please read:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
This patch should be for net, and you need a Fixes: tag.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-05-09 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 7:18 [PATCH] net: dsa: microchip: linearize skb for tail-tagging switches Jakob Unterwurzacher
2025-05-09 12:31 ` Andrew Lunn [this message]
2025-05-09 12:56 ` Vladimir Oltean
2025-05-10 7:54 ` Jakob Unterwurzacher
2025-05-09 22:18 ` Tristram.Ha
2025-05-10 20:08 ` Jakob Unterwurzacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e76f230c-a513-4185-ae3f-72c033aeeb1e@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=george.mccollister@gmail.com \
--cc=horms@kernel.org \
--cc=jakob.unterwurzacher@cherry.de \
--cc=jakobunt@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=quentin.schulz@cherry.de \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox