From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:38347 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbeCWPDA (ORCPT ); Fri, 23 Mar 2018 11:03:00 -0400 Received: by mail-pg0-f68.google.com with SMTP id a15so4674197pgn.5 for ; Fri, 23 Mar 2018 08:03:00 -0700 (PDT) Subject: Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, David Ahern References: <20180322225757.10377-1-dsa@cumulusnetworks.com> <20180322225757.10377-8-dsa@cumulusnetworks.com> <20180323065010.GM2074@nanopsycho.orion> <03eade79-1727-3a31-8e31-a0a7f51b72cf@cumulusnetworks.com> <20180323150149.GD2125@nanopsycho> From: David Ahern Message-ID: Date: Fri, 23 Mar 2018 09:03:40 -0600 MIME-Version: 1.0 In-Reply-To: <20180323150149.GD2125@nanopsycho> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/23/18 9:01 AM, Jiri Pirko wrote: > Fri, Mar 23, 2018 at 03:31:02PM CET, dsa@cumulusnetworks.com wrote: >> On 3/23/18 12:50 AM, Jiri Pirko wrote: >>>> +void nsim_devlink_setup(struct netdevsim *ns) >>>> +{ >>>> + struct net *net = dev_net(ns->netdev); >>>> + bool *reg_devlink = net_generic(net, nsim_devlink_id); >>>> + struct devlink *devlink; >>>> + int err = -ENOMEM; >>>> + >>>> + /* only one device per namespace controls devlink */ >>>> + if (!*reg_devlink) { >>>> + ns->devlink = NULL; >>>> + return; >>>> + } >>>> + >>>> + devlink = devlink_alloc(&nsim_devlink_ops, 0); >>>> + if (!devlink) >>>> + return; >>>> + >>>> + devlink_net_set(devlink, net); >>>> + err = devlink_register(devlink, &ns->dev); >>> >>> This reg_devlink construct looks odd. Why don't you leave the devlink >>> instance in init_ns? >> >> It is a per-network namespace resource controller. Since struct devlink > > Wait a second. What do you mean by "per-network namespace"? Devlink > instance is always associated with one physical device. Like an ASIC. > > >> has a net entry, the simplest design is to put it into the namespace of >> the controller. Without it, controlling resource sizes in namespace >> 'foobar' has to be done from init_net, which is just wrong. you need to look at how netdevsim creates a device per netdevice.