From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D37CC4332F for ; Fri, 23 Dec 2022 11:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236179AbiLWLco (ORCPT ); Fri, 23 Dec 2022 06:32:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236077AbiLWLck (ORCPT ); Fri, 23 Dec 2022 06:32:40 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F77222BED for ; Fri, 23 Dec 2022 03:32:35 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id u12so1023857ljj.11 for ; Fri, 23 Dec 2022 03:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sBnasNl+f/xenJgHP7GIyyOhONyzVUWiXschE4z7WNY=; b=LFj54pvHuw7qmzit85ld1l+UehIwNgT2FQy+RGtMaP5grAkemH8QZAbpMGe2dFk1zU LBx9xN2eu8+5xEYzcrtUbES0tIe8Dg81K00EnNS6TK4YmwfOB4FSV3DcSR18SHViwdpU B9YhhR6TLLxRYWXzeWLSo6VsAUBK9FyieqRJvLh4FvT87NLUf2G7578hw3KVD0OGrSSb +M/Rsxym4jFO5iYit8+1HiP31lTloZHy7YpxukeR6NeoZF9FU8/hD1YBg50HannGsdN+ NFR6pHYKXGMX2xYVNyR2tldTFYYlxxyqmjtrr4s/UBbsxyPm8vqF59wUE/35xFnIPFRO eVxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sBnasNl+f/xenJgHP7GIyyOhONyzVUWiXschE4z7WNY=; b=uFeBSWcWUr9LoMSBEEV2EQEiGeZzZsY57VDjHi5DM2BkysYRauwEpts0vojBG4fh1/ nGBBp+K7jR2qxYVhVfL2VEnbxr6K4nDfPpjuHqDmbIIH69vUTh5vf1wLnh6ZyUr9rf8G vaWCMFIqTipciGwZQP+Wgo650XGNWyVqkwvgZ6PXrmMQ9vuJXqnap9roZfcmo3n27A9J rAIbDMZ9x23DBxO0zmbnj3lodIMLdrN/DKTnIHeEaW6yBexTsbXsZPNcDBkjXdyFttdT ISP2UFRr1Nf02yIe02z0FBt8Mw4yYxNydm75395oZlJtRwcPTYIQlD+ChrcCZVim0ITB M6KQ== X-Gm-Message-State: AFqh2kpSAfphvX8gpVSCmRjd2Rc+5GL5ttGNxQ8m2U+xkChjje0tGtjj JD3YsUCyxChPUAKq2/eI/6rSew== X-Google-Smtp-Source: AMrXdXu+PWU5lKtLXrjZCdv12/5Pcq1pvhvv3XV8RoHHHb3OtCTT1HJIA4IPXYEM9oX4kKlX+WVTpQ== X-Received: by 2002:a2e:3803:0:b0:279:8e95:a3d with SMTP id f3-20020a2e3803000000b002798e950a3dmr2341593lja.13.1671795153955; Fri, 23 Dec 2022 03:32:33 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id z5-20020a05651c11c500b0027da3a87ff6sm387064ljo.83.2022.12.23.03.32.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 03:32:33 -0800 (PST) Message-ID: Date: Fri, 23 Dec 2022 12:32:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Content-Language: en-US To: MD Danish Anwar , "Andrew F. Davis" , Tero Kristo , Suman Anna , Roger Quadros , YueHaibing , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , andrew@lunn.ch Cc: nm@ti.com, ssantosh@kernel.org, srk@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221223110930.1337536-1-danishanwar@ti.com> <20221223110930.1337536-3-danishanwar@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221223110930.1337536-3-danishanwar@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 23/12/2022 12:09, MD Danish Anwar wrote: > From: Roger Quadros > > This is the Ethernet driver for TI AM654 Silicon rev. 2 > with the ICSSG PRU Sub-system running dual-EMAC firmware. > (...) > + > +/* Memory Usage of : DMEM1 > + * > + */ ??? What's this? > + > +/* Memory Usage of : PA_STAT > + * > + */ Same question. > + > +/*Start of 32 bits PA_STAT counters*/ That's not a Linux coding style. Add spaces and make it readable. Best regards, Krzysztof