From: Martin KaFai Lau <martin.lau@linux.dev>
To: Paolo Abeni <pabeni@redhat.com>, Lin Ma <linma@zju.edu.cn>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
ast@kernel.org, martin.lau@kernel.org, yhs@fb.com,
void@manifault.com, andrii@kernel.org, houtao1@huawei.com,
inwardvessel@gmail.com, kuniyu@amazon.com, songliubraving@fb.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v2] bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing
Date: Fri, 28 Jul 2023 16:57:43 -0700 [thread overview]
Message-ID: <e79da177-361a-07fb-710a-967a19d5c7a9@linux.dev> (raw)
In-Reply-To: <c4ca108f891718188ea2a9560324d23de2740565.camel@redhat.com>
On 7/27/23 12:34 AM, Paolo Abeni wrote:
> On Tue, 2023-07-25 at 10:33 +0800, Lin Ma wrote:
>> The nla_for_each_nested parsing in function bpf_sk_storage_diag_alloc
>> does not check the length of the nested attribute. This can lead to an
>> out-of-attribute read and allow a malformed nlattr (e.g., length 0) to
>> be viewed as a 4 byte integer.
>>
>> This patch adds an additional check when the nlattr is getting counted.
>> This makes sure the latter nla_get_u32 can access the attributes with
>> the correct length.
>>
>> Fixes: 1ed4d92458a9 ("bpf: INET_DIAG support in bpf_sk_storage")
>> Suggested-by: Jakub Kicinski <kuba@kernel.org>
>> Signed-off-by: Lin Ma <linma@zju.edu.cn>
>
> I guess this should go via the ebpf tree, right? Setting the delegate
> accordingly.
Already applied to the bpf tree. Thanks.
pw-bot seems not doing auto-reply for the bpf tree.
prev parent reply other threads:[~2023-07-28 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 2:33 [PATCH v2] bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing Lin Ma
2023-07-25 4:44 ` Leon Romanovsky
2023-07-25 5:24 ` Lin Ma
2023-07-25 5:54 ` Leon Romanovsky
2023-07-25 6:05 ` Lin Ma
2023-07-26 3:11 ` Jakub Kicinski
2023-07-27 7:34 ` Paolo Abeni
2023-07-28 23:57 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e79da177-361a-07fb-710a-967a19d5c7a9@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=houtao1@huawei.com \
--cc=inwardvessel@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=songliubraving@fb.com \
--cc=void@manifault.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).