Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support

[Heiner Kallweit <hkallweit1@gmail.com>]

On 22.05.2019 22:07, Florian Fainelli wrote:
> On 5/22/19 12:58 PM, Heiner Kallweit wrote:
>> So far we didn't support mode USXGMII, and in order to not break the
>> two Freescale boards mode XGMII was accepted for the AQR107 family
>> even though it doesn't support XGMII. Add USXGMII support to the
>> Aquantia PHY driver and change the phy connection type for the two
>> boards.
>>
>> As an additional note: Even though the handle is named aqr106
>> there seem to be LS1046A boards with an AQR107.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> You can probably split the DTS changes and the PHY driver changes into a
> separate commits and just have the DTS changes come last? With that:
> 
To split the patches I would have to do:
1. Add USXGMII support to Aquantia PHY driver
2. DTS changes
3. Don't accept XGMII any longer in Aquantia PHY driver
This seemed to me to be too much overhead considering the very small
change.

Just making the DTS changes a separate patch would break bisecting.

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>