From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Anton Aksola <aakso@iki.fi>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it
Date: Fri, 16 Sep 2016 17:43:05 +0200 [thread overview]
Message-ID: <e7c6471e-66ea-aaac-40e8-6dd54792ad91@6wind.com> (raw)
In-Reply-To: <20160916131804.GA19216@toys.tundra.dog-lvm.novalocal>
Le 16/09/2016 à 15:18, Anton Aksola a écrit :
[snip]
> Nicolas,
> This seems to be caused by netns_add calling unshare(CLONE_NEWNET).
> If we initialize the socket for nsid after that it doesn't seem to work.
>
> Unfortunately I'm not an expert in these details. Should we separate the
> socket and cache initialization to different functions and call the
> socket init in the beginning of do_netns() as before? What do you think?
Seems good.
> I made a quick patch and it seems to work in batch mode now.
What is the result of that sequence?
$ ip netns add bar
$ ip netns set bar 5678
$ ip -b test.batch
nsid 1234 (iproute2 netns name: foo)
nsid 5678 (iproute2 netns name: bar)
$
prev parent reply other threads:[~2016-09-16 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 7:22 [PATCH v2] iproute2: build nsid-name cache only for commands that need it Anton Aksola
2016-09-16 9:13 ` Nicolas Dichtel
2016-09-16 9:23 ` Vadim Kochan
2016-09-16 9:44 ` Nicolas Dichtel
[not found] ` <CAAL2ahKKFWcxhA=k+=3Td8sb-upnRUFs373EOhkHDaxvcgYjOw@mail.gmail.com>
2016-09-16 11:25 ` Vadim Kochan
2016-09-16 12:02 ` Anton Aksola
2016-09-16 13:18 ` Anton Aksola
2016-09-16 15:43 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7c6471e-66ea-aaac-40e8-6dd54792ad91@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=aakso@iki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox