From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Subject: Re: [PATCH] net: caif: remove redundant null check on frontpkt Date: Fri, 14 Sep 2018 19:18:45 +0100 Message-ID: References: <20180914171916.21298-1-colin.king@canonical.com> <47b7f5a0-8b13-ead7-33b7-6e9c6ada8e61@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org To: Sergei Shtylyov , Dmitry Tarnyagin , "David S . Miller" Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:38117 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726849AbeINXe1 (ORCPT ); Fri, 14 Sep 2018 19:34:27 -0400 In-Reply-To: <47b7f5a0-8b13-ead7-33b7-6e9c6ada8e61@cogentembedded.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 14/09/18 18:54, Sergei Shtylyov wrote: > Hello! > > On 09/14/2018 08:19 PM, Colin King wrote: > >> From: Colin Ian King >> >> It is impossible for frontpkt to be null at the point of the null >> check because it has been assigned from rearpkt and there is no >> way realpkt can be null at the point of the assignment because > > rearpkt? Good spot. Can this be fixed up when the patch is applied? > >> of the sanity checking and exit paths taken previously. Remove >> the redundant null check. >> >> Detected by CoverityScan, CID#114434 ("Logically dead code") >> >> Signed-off-by: Colin Ian King > [...] > > MBR, Sergei >