From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer Date: Mon, 5 Mar 2018 10:39:14 +0800 Message-ID: References: <1519982954-14360-1-git-send-email-jasowang@redhat.com> <20180302170758.332600d6@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, john.fastabend@gmail.com To: Jesper Dangaard Brouer Return-path: In-Reply-To: <20180302170758.332600d6@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote: > On Fri, 2 Mar 2018 17:29:14 +0800 > Jason Wang wrote: > >> XDP_REDIRECT support for mergeable buffer was removed since commit >> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() >> case"). This is because we don't reserve enough tailroom for struct >> skb_shared_info which breaks XDP assumption. So this patch fixes this >> by reserving enough tailroom and using fixed size of rx buffer. >> >> Signed-off-by: Jason Wang >> --- >> Changes from V1: >> - do not add duplicated tracepoint when redirection fails > Acked-by: Jesper Dangaard Brouer > > I gave it a quick spin on my testlab, and cpumap seems to > work/not-crash now (if I managed to turn back config to > receive_mergeable() correctly ;-)). > Thanks for the testing and reviewing.