* [PATCH iproute2-next] tunnel: Fix missing space after local/remote print
@ 2022-02-08 14:40 Gal Pressman
2022-02-08 17:57 ` Stephen Hemminger
0 siblings, 1 reply; 5+ messages in thread
From: Gal Pressman @ 2022-02-08 14:40 UTC (permalink / raw)
To: Stephen Hemminger, David Ahern; +Cc: netdev, Gal Pressman
The cited commit removed the space after the local/remote tunnel print
and resulted in "broken" output:
gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
ip/tunnel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ip/tunnel.c b/ip/tunnel.c
index f2632f43babf..7200ce831317 100644
--- a/ip/tunnel.c
+++ b/ip/tunnel.c
@@ -299,6 +299,8 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
}
print_string_name_value(name, value);
+ if (!is_json_context())
+ print_string(PRINT_FP, NULL, " ", NULL);
}
void tnl_print_gre_flags(__u8 proto,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH iproute2-next] tunnel: Fix missing space after local/remote print
2022-02-08 14:40 [PATCH iproute2-next] tunnel: Fix missing space after local/remote print Gal Pressman
@ 2022-02-08 17:57 ` Stephen Hemminger
2022-02-09 6:51 ` Gal Pressman
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2022-02-08 17:57 UTC (permalink / raw)
To: Gal Pressman; +Cc: David Ahern, netdev
On Tue, 8 Feb 2022 16:40:05 +0200
Gal Pressman <gal@nvidia.com> wrote:
> The cited commit removed the space after the local/remote tunnel print
> and resulted in "broken" output:
>
> gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> ---
> ip/tunnel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ip/tunnel.c b/ip/tunnel.c
> index f2632f43babf..7200ce831317 100644
> --- a/ip/tunnel.c
> +++ b/ip/tunnel.c
> @@ -299,6 +299,8 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
> }
>
> print_string_name_value(name, value);
> + if (!is_json_context())
> + print_string(PRINT_FP, NULL, " ", NULL);
is_json_context is not needed here.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH iproute2-next] tunnel: Fix missing space after local/remote print
2022-02-08 17:57 ` Stephen Hemminger
@ 2022-02-09 6:51 ` Gal Pressman
0 siblings, 0 replies; 5+ messages in thread
From: Gal Pressman @ 2022-02-09 6:51 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Ahern, netdev
On 08/02/2022 19:57, Stephen Hemminger wrote:
> On Tue, 8 Feb 2022 16:40:05 +0200
> Gal Pressman <gal@nvidia.com> wrote:
>
>> The cited commit removed the space after the local/remote tunnel print
>> and resulted in "broken" output:
>>
>> gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
>> Signed-off-by: Gal Pressman <gal@nvidia.com>
>> ---
>> ip/tunnel.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/ip/tunnel.c b/ip/tunnel.c
>> index f2632f43babf..7200ce831317 100644
>> --- a/ip/tunnel.c
>> +++ b/ip/tunnel.c
>> @@ -299,6 +299,8 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
>> }
>>
>> print_string_name_value(name, value);
>> + if (!is_json_context())
>> + print_string(PRINT_FP, NULL, " ", NULL);
> is_json_context is not needed here.
Thanks, will remove.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH iproute2-next] tunnel: Fix missing space after local/remote print
@ 2022-02-09 6:54 Gal Pressman
2022-02-10 18:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 5+ messages in thread
From: Gal Pressman @ 2022-02-09 6:54 UTC (permalink / raw)
To: Stephen Hemminger, David Ahern; +Cc: netdev, Gal Pressman
The cited commit removed the space after the local/remote tunnel print
and resulted in "broken" output:
gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
v1->v2: https://lore.kernel.org/netdev/20220208144005.32401-1-gal@nvidia.com/
* Remove unneeded is_json_context()
---
ip/tunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ip/tunnel.c b/ip/tunnel.c
index f2632f43babf..224c81e42e9b 100644
--- a/ip/tunnel.c
+++ b/ip/tunnel.c
@@ -299,6 +299,7 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
}
print_string_name_value(name, value);
+ print_string(PRINT_FP, NULL, " ", NULL);
}
void tnl_print_gre_flags(__u8 proto,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-10 18:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08 14:40 [PATCH iproute2-next] tunnel: Fix missing space after local/remote print Gal Pressman
2022-02-08 17:57 ` Stephen Hemminger
2022-02-09 6:51 ` Gal Pressman
-- strict thread matches above, loose matches on Subject: below --
2022-02-09 6:54 Gal Pressman
2022-02-10 18:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).