Re: [PATCH net-next v4 2/7] phy: add hwtstamp_get callback to phy drivers

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 20/11/2025 17:51, Kory Maincent wrote:
> On Thu, 20 Nov 2025 17:45:35 +0000
> Vadim Fedorenko <vadim.fedorenko@linux.dev> wrote:
> 
>> PHY devices had lack of hwtstamp_get callback even though most of them
>> are tracking configuration info. Introduce new call back to
>> mii_timestamper.
> 
> It's a pity you didn't take my comment into account. :/
> 
> " It would be nice to update this kdoc note:
> https://elixir.bootlin.com/linux/v6.18-rc6/source/net/core/dev_ioctl.c#L252 "

Oh, sorry Kory, totally forgot about this change. Will make it into v5
ASAP

> 
>> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>> Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
>> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>> ---
>>   drivers/net/phy/phy.c           | 3 +++
>>   include/linux/mii_timestamper.h | 5 +++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
>> index 350bc23c1fdb..13dd1691886d 100644
>> --- a/drivers/net/phy/phy.c
>> +++ b/drivers/net/phy/phy.c
>> @@ -478,6 +478,9 @@ int __phy_hwtstamp_get(struct phy_device *phydev,
>>   	if (!phydev)
>>   		return -ENODEV;
>>   
>> +	if (phydev->mii_ts && phydev->mii_ts->hwtstamp_get)
>> +		return phydev->mii_ts->hwtstamp_get(phydev->mii_ts, config);
>> +
>>   	return -EOPNOTSUPP;
>>   }
>>   
>> diff --git a/include/linux/mii_timestamper.h b/include/linux/mii_timestamper.h
>> index 08863c0e9ea3..3102c425c8e0 100644
>> --- a/include/linux/mii_timestamper.h
>> +++ b/include/linux/mii_timestamper.h
>> @@ -29,6 +29,8 @@ struct phy_device;
>>    *
>>    * @hwtstamp_set: Handles SIOCSHWTSTAMP ioctl for hardware time stamping.
>>    *
>> + * @hwtstamp_get: Handles SIOCGHWTSTAMP ioctl for hardware time stamping.
>> + *
>>    * @link_state: Allows the device to respond to changes in the link
>>    *		state.  The caller invokes this function while holding
>>    *		the phy_device mutex.
>> @@ -55,6 +57,9 @@ struct mii_timestamper {
>>   			     struct kernel_hwtstamp_config *kernel_config,
>>   			     struct netlink_ext_ack *extack);
>>   
>> +	int  (*hwtstamp_get)(struct mii_timestamper *mii_ts,
>> +			     struct kernel_hwtstamp_config *kernel_config);
>> +
>>   	void (*link_state)(struct mii_timestamper *mii_ts,
>>   			   struct phy_device *phydev);
>>   
> 
> 
>