From: David Ahern <dsahern@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, petrm@nvidia.com, mlxsw@nvidia.com
Subject: Re: [PATCH net-next 2/2] nexthop: Do not increment dump sentinel at the end of the dump
Date: Sun, 13 Aug 2023 19:22:33 -0600 [thread overview]
Message-ID: <e8af35a8-00c6-2fb4-1f25-2efb2d3cb00c@kernel.org> (raw)
In-Reply-To: <20230813164856.2379822-3-idosch@nvidia.com>
On 8/13/23 10:48 AM, Ido Schimmel wrote:
> The nexthop and nexthop bucket dump callbacks previously returned a
> positive return code even when the dump was complete, prompting the core
> netlink code to invoke the callback again, until returning zero.
>
> Zero was only returned by these callbacks when no information was filled
> in the provided skb, which was achieved by incrementing the dump
> sentinel at the end of the dump beyond the ID of the last nexthop.
>
> This is no longer necessary as when the dump is complete these callbacks
> return zero.
>
> Remove the unnecessary increment.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> ---
> net/ipv4/nexthop.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-08-14 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 16:48 [PATCH net-next 0/2] nexthop: Various cleanups Ido Schimmel
2023-08-13 16:48 ` [PATCH net-next 1/2] nexthop: Simplify nexthop bucket dump Ido Schimmel
2023-08-14 1:20 ` David Ahern
2023-08-13 16:48 ` [PATCH net-next 2/2] nexthop: Do not increment dump sentinel at the end of the dump Ido Schimmel
2023-08-14 1:22 ` David Ahern [this message]
2023-08-16 2:00 ` [PATCH net-next 0/2] nexthop: Various cleanups patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8af35a8-00c6-2fb4-1f25-2efb2d3cb00c@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).