From: Markus Elfring <Markus.Elfring@web.de>
To: Fan Gong <gongfan1@huawei.com>,
Zhu Yikai <zhuyikai1@h-partners.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Simon Horman <horms@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Gur Stavi <gur.stavi@huawei.com>,
luosifu@huawei.com, Luo Yang <luoyang82@h-partners.com>,
Meny Yossefi <meny.yossefi@huawei.com>,
Shen Chenyang <shenchenyang1@hisilicon.com>,
Shi Jing <shijing34@huawei.com>, Wu Like <wulike1@huawei.com>,
Xin Guo <guoxin09@huawei.com>,
Zhou Shuai <zhoushuai28@huawei.com>
Subject: Re: [PATCH net-next v02 4/6] hinic3: Add mac filter ops
Date: Fri, 17 Oct 2025 13:51:03 +0200 [thread overview]
Message-ID: <e8b52cf3-9f77-445c-8ba6-d8ac402841b7@web.de> (raw)
In-Reply-To: <dccaa516308f83aed2058175fdb4b752b6cbf4ae.1760685059.git.zhuyikai1@h-partners.com>
…> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_filter.c
> @@ -0,0 +1,413 @@
…> +static int hinic3_mac_filter_sync(struct net_device *netdev,
> + struct list_head *mac_filter_list, bool uc)
> +{
…
> + hinic3_cleanup_filter_list(&tmp_add_list);> + hinic3_mac_filter_sync_hw(netdev, &tmp_del_list, &tmp_add_list);
> +
> + /* need to enter promiscuous/allmulti mode */
> + err = -ENOMEM;
> + goto err_out;
> + }
> +
> + return add_count;
> +
> +err_out:
> + return err;
> +}
Is there a need to move any resource cleanup actions behind a more appropriate label?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17#n532
Regards,
Markus
next prev parent reply other threads:[~2025-10-17 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 8:30 [PATCH net-next v02 0/6] net: hinic3: PF initialization Fan Gong
2025-10-17 8:30 ` [PATCH net-next v02 1/6] hinic3: Add PF framework Fan Gong
2025-10-21 9:16 ` Paolo Abeni
2025-10-17 8:30 ` [PATCH net-next v02 2/6] hinic3: Add PF management interfaces Fan Gong
2025-10-21 9:25 ` Paolo Abeni
2025-10-17 8:30 ` [PATCH net-next v02 3/6] hinic3: Add NIC configuration ops Fan Gong
2025-10-21 10:02 ` Paolo Abeni
2025-10-17 8:30 ` [PATCH net-next v02 4/6] hinic3: Add mac filter ops Fan Gong
2025-10-17 11:51 ` Markus Elfring [this message]
2025-10-20 1:29 ` Fan Gong
2025-10-21 10:16 ` Paolo Abeni
2025-10-17 8:30 ` [PATCH net-next v02 5/6] hinic3: Add netdev register interfaces Fan Gong
2025-10-17 8:30 ` [PATCH net-next v02 6/6] hinic3: Fix netif_queue_set_napi queue_index parameter passing error Fan Gong
2025-10-21 10:22 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b52cf3-9f77-445c-8ba6-d8ac402841b7@web.de \
--to=markus.elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=luoyang82@h-partners.com \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox