From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27117C48BD5 for ; Tue, 25 Jun 2019 10:04:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8020215EA for ; Tue, 25 Jun 2019 10:04:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tnNPtYBv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731853AbfFYKEy (ORCPT ); Tue, 25 Jun 2019 06:04:54 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:56120 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbfFYKEy (ORCPT ); Tue, 25 Jun 2019 06:04:54 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5PA4nub062386; Tue, 25 Jun 2019 05:04:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1561457089; bh=P/SKDRzg6dvG83d820OF33YKZOlXQ/dcokiyRm5jtFc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=tnNPtYBvq0/Yfx2zSsRQaGvcpfIolg/EwKSFKH62pwS3DTWQrENKYwZThgO4UKpwB 7nZMth6gzj/dQZsxl4dGNtlIJIfXnee87fJptL0wZGptuNDWWgb/QY9nhiRwbApnk2 P7O6MfDgHUY6eOl2Fo7xUNEvE0KsnGK8cbjoIhFg= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5PA4nro037894 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Jun 2019 05:04:49 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 25 Jun 2019 05:04:49 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 25 Jun 2019 05:04:49 -0500 Received: from [10.250.132.197] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5PA4g3K005525; Tue, 25 Jun 2019 05:04:43 -0500 Subject: Re: [PATCH V2] net: ethernet: ti: cpsw: Fix suspend/resume break To: David Miller CC: , , , , , , , , References: <20190624051619.20146-1-j-keerthy@ti.com> <20190624.072333.2300932810459542260.davem@davemloft.net> From: keerthy Message-ID: Date: Tue, 25 Jun 2019 15:34:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190624.072333.2300932810459542260.davem@davemloft.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/24/2019 7:53 PM, David Miller wrote: > From: Keerthy > Date: Mon, 24 Jun 2019 10:46:19 +0530 > >> Commit bfe59032bd6127ee190edb30be9381a01765b958 ("net: ethernet: >> ti: cpsw: use cpsw as drv data")changes >> the driver data to struct cpsw_common *cpsw. This is done >> only in probe/remove but the suspend/resume functions are >> still left with struct net_device *ndev. Hence fix both >> suspend & resume also to fetch the updated driver data. >> >> Fixes: bfe59032bd6127ee1 ("net: ethernet: ti: cpsw: use cpsw as drv data") >> Signed-off-by: Keerthy > > Applied but please make it clear that changes are targetting net-next in the > future by saying "[PATCH net-next v2] ...." in your Subject line. Sure will do that. Thanks. > > Thank you. >