Netdev List
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
	Michal Schmidt <mschmidt@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>, <edumazet@google.com>,
	<horms@kernel.org>, <pabeni@redhat.com>, <davem@davemloft.net>
Subject: Re: [PATCH net v5 0/6] ice: fix stats array overflow via proper realloc
Date: Wed, 30 Sep 2026 13:55:51 +0200	[thread overview]
Message-ID: <e917c70b-a0db-4c5d-8fa0-219ee77b49ea@intel.com> (raw)
In-Reply-To: <20260925132636.123300-1-przemyslaw.kitszel@intel.com>

On 9/25/26 3:15 PM, Przemek Kitszel wrote:
> Fix OOB access to the stats arrays.
> 
> The first commit (new in v5) fixes stats code against VSI_CHNL case (ADQ).
> 
> Next three commits are simple refactors to make the rest smaller,
> the fifth one untangles the logic/lifetime of the stats array entries,
> then we have the final fix for OOB access to the stats array (combined
> for both PF and VF VSIs.
> 
> v5 handles now also the PF VSI stats resizes better, fixing devlink reload
> issue reported in v4 by Clashiko.
> 
> v0
> https://lore.kernel.org/netdev/20260520183501.3360810-3-anthony.l.nguyen@intel.com
> v2
> https://sashiko.dev/#/message/20260812204619.32253-3-przemyslaw.kitszel%40intel.com
> v4 (a resend of ~the same v3)
> https://lore.kernel.org/netdev/20260921182106.1015019-1-anthony.l.nguyen@intel.com
> 
> Most notable changes in v5 already noted in the cover letter, individual patches
> have much more notes.
> ---
> 
> 
> Przemek Kitszel (6):
>    ice: skip stats handling for channel VSIs on rebuild
>    ice: extract __ice_vsi_free_stats()
>    ice: extract ice_vsi_new_stat_arrays()
>    ice: extract ice_vsi_get_num_qs()
>    ice: rebuild ring stats arrays instead of reallocating them in place
>    ice: size ring stats arrays from the final queue count
> 
>   drivers/net/ethernet/intel/ice/ice.h     |   8 +-
>   drivers/net/ethernet/intel/ice/ice_lib.c | 343 ++++++++++++++---------
>   2 files changed, 210 insertions(+), 141 deletions(-)
> 

I've replied to all not pre-existing issues. My ask is to merge as-is.

  parent reply	other threads:[~2026-09-30 11:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 13:15 [PATCH net v5 0/6] ice: fix stats array overflow via proper realloc Przemek Kitszel
2026-09-25 13:15 ` [PATCH net v5 1/6] ice: skip stats handling for channel VSIs on rebuild Przemek Kitszel
2026-09-25 14:29   ` Loktionov, Aleksandr
2026-09-29 14:04   ` netdev-bot+sashiko
2026-09-30 11:54     ` Przemek Kitszel
2026-09-29 18:02   ` Jacob Keller
2026-09-25 13:15 ` [PATCH net v5 2/6] ice: extract __ice_vsi_free_stats() Przemek Kitszel
2026-09-25 14:30   ` Loktionov, Aleksandr
2026-09-29 14:04   ` netdev-bot+sashiko
2026-09-30 11:54     ` Przemek Kitszel
2026-09-25 13:15 ` [PATCH net v5 3/6] ice: extract ice_vsi_new_stat_arrays() Przemek Kitszel
2026-09-25 14:30   ` Loktionov, Aleksandr
2026-09-25 13:15 ` [PATCH net v5 4/6] ice: extract ice_vsi_get_num_qs() Przemek Kitszel
2026-09-25 14:31   ` Loktionov, Aleksandr
2026-09-25 13:15 ` [PATCH net v5 5/6] ice: rebuild ring stats arrays instead of reallocating them in place Przemek Kitszel
2026-09-25 14:32   ` Loktionov, Aleksandr
2026-09-29 14:04   ` netdev-bot+sashiko
2026-09-30 11:54     ` Przemek Kitszel
2026-09-25 13:15 ` [PATCH net v5 6/6] ice: size ring stats arrays from the final queue count Przemek Kitszel
2026-09-25 14:32   ` Loktionov, Aleksandr
2026-09-29 14:04   ` netdev-bot+sashiko
2026-09-30 11:54     ` Przemek Kitszel
2026-09-30 11:55 ` Przemek Kitszel [this message]
2026-09-30 21:01   ` [PATCH net v5 0/6] ice: fix stats array overflow via proper realloc Jakub Kicinski
2026-09-30 21:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e917c70b-a0db-4c5d-8fa0-219ee77b49ea@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox