From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f52.google.com ([74.125.83.52]:35812 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S938555AbeBUQKR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 21 Feb 2018 11:10:17 -0500
Subject: Re: [PATCH iproute2-next] rdma: Add batch command support
To: Leon Romanovsky <leon@kernel.org>
Cc: Leon Romanovsky <leonro@mellanox.com>,
        netdev <netdev@vger.kernel.org>,
        Stephen Hemminger <stephen@networkplumber.org>,
        RDMA mailing list <linux-rdma@vger.kernel.org>
References: <20180221123825.3042-1-leon@kernel.org>
From: David Ahern <dsahern@gmail.com>
Message-ID: <e9261305-a82e-452d-8da9-07accddfebb4@gmail.com>
Date: Wed, 21 Feb 2018 09:10:45 -0700
MIME-Version: 1.0
In-Reply-To: <20180221123825.3042-1-leon@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2/21/18 5:38 AM, Leon Romanovsky wrote:
> @@ -36,17 +37,54 @@ static int rd_cmd(struct rd *rd)
>  		{ 0 }
>  	};
> 
> +	rd->argc = argc;
> +	rd->argv = argv;
> +
>  	return rd_exec_cmd(rd, cmds, "object");
>  }
> 
> -static int rd_init(struct rd *rd, int argc, char **argv, char *filename)
> +static int rd_batch(struct rd *rd, const char *name, bool force)
> +{
> +	char *line = NULL;
> +	size_t len = 0;
> +	int ret = 0;
> +
> +	if (name && strcmp(name, "-") != 0) {
> +		if (!freopen(name, "r", stdin)) {
> +			pr_err("Cannot open file \"%s\" for reading: %s\n",
> +			       name, strerror(errno));
> +			return errno;
> +		}
> +	}
> +
> +	cmdlineno = 0;
> +	while (getcmdline(&line, &len, stdin) != -1) {
> +		char *largv[512];
> +		int largc;
> +
> +		largc = makeargs(line, largv, 100);

you have largv[512] declared but passing a max of 100. I realize other
batch commands have it hardcoded, but ARRAY_SIZE is better.