From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next 0/4] bridge: implement Multicast Router Discovery (RFC4286) Date: Fri, 21 Dec 2018 17:37:32 +0200 Message-ID: References: <20181221151511.14923-1-linus.luessing@c0d3.blue> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Roopa Prabhu , Alexey Kuznetsov , Hideaki YOSHIFUJI , "David S . Miller" , bridge@lists.linux-foundation.org, b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org To: =?UTF-8?Q?Linus_L=c3=bcssing?= , netdev@vger.kernel.org Return-path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:33893 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbeLUPho (ORCPT ); Fri, 21 Dec 2018 10:37:44 -0500 Received: by mail-wr1-f65.google.com with SMTP id j2so5721941wrw.1 for ; Fri, 21 Dec 2018 07:37:43 -0800 (PST) In-Reply-To: <20181221151511.14923-1-linus.luessing@c0d3.blue> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/21/18 5:15 PM, Linus Lüssing wrote: > Hi, > > This patchset adds initial Multicast Router Discovery support to > the Linux bridge (RFC4286). With MRD it is possible to detect multicast > routers and mark bridge ports and forward multicast packets to such routers > accordingly. > > So far, multicast routers are detected via IGMP/MLD queries and PIM > messages in the Linux bridge. As there is only one active, selected > querier at a time RFC4541 ("Considerations for Internet Group Management > Protocol (IGMP) and Multicast Listener Discovery (MLD) Snooping > Switches") section 2.1.1.a) recommends snooping Multicast Router > Advertisements as provided by MRD (RFC4286). > > > The first two patches are refactoring some existing code which is reused > for parsing the Multicast Router Advertisements later in the fourth > patch. The third patch lets the bridge join the all-snoopers multicast > address to be able to reliably receive the Multicast Router > Advertisements. > > > What is not implemented yet from RFC4286 yet: > > * Sending Multicast Router Solicitations: > -> RFC4286: "[...] may be sent when [...] an interface is > (re-)initialized [or] MRD is enabled" > * Snooping Multicast Router Terminations: > -> currently this only relies on our own timeouts > * Adjusting timeouts with the values provided in the announcements > > > Regards, Linus > > > Hi Linus, Nice work, unfortunately net-next is currenty closed. Anyway I'll review the patches in detail after the holidays so if there's anything it can be adjusted for when net-next opens up. Thanks, Nik