Netdev List
 help / color / mirror / Atom feed
From: Sidraya Jayagond <sidraya@linux.ibm.com>
To: Jiayuan Chen <jiayuan.chen@linux.dev>, netdev@vger.kernel.org
Cc: Dust Li <dust.li@linux.alibaba.com>,
	David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Matthieu Baerts <matttbe@kernel.org>,
	Mat Martineau <martineau@kernel.org>,
	Geliang Tang <geliang@kernel.org>,
	Allison Henderson <achender@kernel.org>,
	"D. Wythe" <alibuda@linux.alibaba.com>,
	Mahanta Jambigi <mjambigi@linux.ibm.com>,
	Tony Lu <tonylu@linux.alibaba.com>,
	Wen Gu <guwen@linux.alibaba.com>,
	linux-kernel@vger.kernel.org, mptcp@lists.linux.dev,
	linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/5] net/smc: annotate data-races around smc sysctls
Date: Thu, 19 Nov 2026 12:53:50 +0530	[thread overview]
Message-ID: <e9389120-778a-46f2-93e3-aad966bd148c@linux.ibm.com> (raw)
In-Reply-To: <20261118045137.174026-6-jiayuan.chen@linux.dev>



On 18/11/26 10:21 am, Jiayuan Chen wrote:
> autocorking_size, smcr_buf_type, smcr_max_links_per_lgr,
> smcr_max_conns_per_lgr and limit_smc_hs are read without any lock while
> their sysctl handlers update them with WRITE_ONCE(), and the SMC netlink
> handlers toggle limit_smc_hs with plain writes. Add READ_ONCE() to the
> readers and WRITE_ONCE() to those handlers.
> 
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
> Acked-by: Dust Li <dust.li@linux.alibaba.com>
> ---
>  net/smc/af_smc.c   | 8 ++++----
>  net/smc/smc_clc.c  | 8 ++++----
>  net/smc/smc_core.c | 2 +-
>  net/smc/smc_tx.c   | 2 +-
>  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index bfc0c7e71a12b..1d3eae064fe0d 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -88,7 +88,7 @@ int smc_nl_dump_hs_limitation(struct sk_buff *skb, struct netlink_callback *cb)
>  		return -ENOMEM;
>  
>  	if (nla_put_u8(skb, SMC_NLA_HS_LIMITATION_ENABLED,
> -		       sock_net(skb->sk)->smc.limit_smc_hs))
> +		       READ_ONCE(sock_net(skb->sk)->smc.limit_smc_hs)))
>  		goto err;
>  
>  	genlmsg_end(skb, hdr);
> @@ -102,13 +102,13 @@ int smc_nl_dump_hs_limitation(struct sk_buff *skb, struct netlink_callback *cb)
>  
>  int smc_nl_enable_hs_limitation(struct sk_buff *skb, struct genl_info *info)
>  {
> -	sock_net(skb->sk)->smc.limit_smc_hs = true;
> +	WRITE_ONCE(sock_net(skb->sk)->smc.limit_smc_hs, true);
>  	return 0;
>  }
>  
>  int smc_nl_disable_hs_limitation(struct sk_buff *skb, struct genl_info *info)
>  {
> -	sock_net(skb->sk)->smc.limit_smc_hs = false;
> +	WRITE_ONCE(sock_net(skb->sk)->smc.limit_smc_hs, false);
>  	return 0;
>  }
>  
> @@ -411,7 +411,7 @@ void smc_sk_init(struct net *net, struct sock *sk, int protocol)
>  	spin_lock_init(&smc->conn.send_lock);
>  	mutex_init(&smc->clcsock_release_lock);
>  	smc_init_saved_callbacks(smc);
> -	smc->limit_smc_hs = net->smc.limit_smc_hs;
> +	smc->limit_smc_hs = READ_ONCE(net->smc.limit_smc_hs);
>  	smc->use_fallback = false; /* assume rdma capability first */
>  	smc->fallback_rsn = 0;
>  	smc_close_init(smc);
> diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
> index 014d527d5462d..df0afeef67cbd 100644
> --- a/net/smc/smc_clc.c
> +++ b/net/smc/smc_clc.c
> @@ -990,8 +990,8 @@ int smc_clc_send_proposal(struct smc_sock *smc, struct smc_init_info *ini)
>  	}
>  	if (smcr_indicated(ini->smc_type_v2)) {
>  		memcpy(v2_ext->roce, ini->smcrv2.ib_gid_v2, SMC_GID_SIZE);
> -		v2_ext->max_conns = net->smc.sysctl_max_conns_per_lgr;
> -		v2_ext->max_links = net->smc.sysctl_max_links_per_lgr;
> +		v2_ext->max_conns = READ_ONCE(net->smc.sysctl_max_conns_per_lgr);
> +		v2_ext->max_links = READ_ONCE(net->smc.sysctl_max_links_per_lgr);
>  	}
>  
>  	pclc_base->hdr.length = htons(plen);
> @@ -1272,12 +1272,12 @@ int smc_clc_srv_v2x_features_validate(struct smc_sock *smc,
>  
>  	if (ini->smcr_version & SMC_V2) {
>  		ini->max_conns = min_t(u8, pclc_v2_ext->max_conns,
> -				       net->smc.sysctl_max_conns_per_lgr);
> +				       READ_ONCE(net->smc.sysctl_max_conns_per_lgr));
>  		if (ini->max_conns < SMC_CONN_PER_LGR_MIN)
>  			return SMC_CLC_DECL_MAXCONNERR;
>  
>  		ini->max_links = min_t(u8, pclc_v2_ext->max_links,
> -				       net->smc.sysctl_max_links_per_lgr);
> +				       READ_ONCE(net->smc.sysctl_max_links_per_lgr));
>  		if (ini->max_links < SMC_LINKS_ADD_LNK_MIN)
>  			return SMC_CLC_DECL_MAXLINKERR;
>  	}
> diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
> index a3164201c1420..2db3a87054835 100644
> --- a/net/smc/smc_core.c
> +++ b/net/smc/smc_core.c
> @@ -1010,7 +1010,7 @@ static int smc_lgr_create(struct smc_sock *smc, struct smc_init_info *ini)
>  		lgr->net = smc_ib_net(lnk->smcibdev);
>  		lgr_list = &smc_lgr_list.list;
>  		lgr_lock = &smc_lgr_list.lock;
> -		lgr->buf_type = lgr->net->smc.sysctl_smcr_buf_type;
> +		lgr->buf_type = READ_ONCE(lgr->net->smc.sysctl_smcr_buf_type);
>  		atomic_inc(&lgr_cnt);
>  	}
>  	smc->conn.lgr = lgr;
> diff --git a/net/smc/smc_tx.c b/net/smc/smc_tx.c
> index 0f0c6df3bf2ce..30bffe79d06a3 100644
> --- a/net/smc/smc_tx.c
> +++ b/net/smc/smc_tx.c
> @@ -148,7 +148,7 @@ static bool smc_should_autocork(struct smc_sock *smc)
>  	int corking_size;
>  
>  	corking_size = min_t(unsigned int, conn->sndbuf_desc->len >> 1,
> -			     sock_net(&smc->sk)->smc.sysctl_autocorking_size);
> +			     READ_ONCE(sock_net(&smc->sk)->smc.sysctl_autocorking_size));
>  
>  	if (atomic_read(&conn->cdc_pend_tx_wr) == 0 ||
>  	    smc_tx_prepared_sends(conn) > corking_size)

Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>

Regards,
Sidraya

      reply	other threads:[~2026-11-19  7:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  4:51 [PATCH net-next v2 0/5] net: annotate data-races around sysctl knobs Jiayuan Chen
2026-11-18  4:51 ` [PATCH net-next v2 1/5] inet: frags: annotate data-races around fqdir->timeout and fqdir->max_dist Jiayuan Chen
2026-11-18  4:51 ` [PATCH net-next v2 2/5] ipv6: annotate data-races around icmpv6 reply sysctls Jiayuan Chen
2026-11-18  4:51 ` [PATCH net-next v2 3/5] mptcp: annotate data-races around pernet sysctls Jiayuan Chen
2026-11-18  4:51 ` [PATCH net-next v2 4/5] rds: annotate data-races around core rds sysctls Jiayuan Chen
2026-11-19  4:53   ` netdev-bot+sashiko
2026-11-18  4:51 ` [PATCH net-next v2 5/5] net/smc: annotate data-races around smc sysctls Jiayuan Chen
2026-11-19  7:23   ` Sidraya Jayagond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9389120-778a-46f2-93e3-aad966bd148c@linux.ibm.com \
    --to=sidraya@linux.ibm.com \
    --cc=achender@kernel.org \
    --cc=alibuda@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=dust.li@linux.alibaba.com \
    --cc=edumazet@kernel.org \
    --cc=geliang@kernel.org \
    --cc=guwen@linux.alibaba.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jiayuan.chen@linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mjambigi@linux.ibm.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    --cc=tonylu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox