From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tom Herbert <tom@herbertland.com>
Cc: Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
AutonomousCodeSecurity@microsoft.com, netdev@vger.kernel.org,
Cen Zhang <cenzhang@linux.microsoft.com>
Subject: Re: [PATCH net 1/2] net: gro: do not undo remote checksum offload on merged packets
Date: Thu, 29 Oct 2026 09:04:49 +0100 [thread overview]
Message-ID: <e93f9302-b2ce-4e3e-b317-f867d80e8643@redhat.com> (raw)
In-Reply-To: <20261028141325.2103814-2-edumazet@kernel.org>
[adding Tom]
On 10/28/26 15:13, Eric Dumazet wrote:
> skb_gro_flush_final_remcsum() calls skb_gro_remcsum_cleanup() to undo
> the checksum adjustment done by skb_gro_remcsum_process() when the
> packet was not consumed by GRO.
I have a meta question _not_ intended to block this series. Is
remcsum offload still a thing? Can we get rid of it entirely?
AFAICS remcsum landed upstream before GSO_PARTIAL, and the latter
does a better job (specifically, it actually validates the inner
hdr csum, while AFAICS remcsum offload basically ignores inner
packet csum).
On the flip side remcsum offload has even lesser device requirements
than GSO_PARTIAL, so possibly some use-case still exists.
Am I missing something?
/P
next prev parent reply other threads:[~2026-10-29 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 14:13 [PATCH net 0/2] net: gro: fix frag0 and remcsum handling Eric Dumazet
2026-10-28 14:13 ` [PATCH net 1/2] net: gro: do not undo remote checksum offload on merged packets Eric Dumazet
2026-10-29 8:04 ` Paolo Abeni [this message]
2026-10-28 14:13 ` [PATCH net 2/2] net: gro: invalidate frag0 after a pull Eric Dumazet
2026-10-28 14:15 ` [PATCH net 0/2] net: gro: fix frag0 and remcsum handling netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e93f9302-b2ce-4e3e-b317-f867d80e8643@redhat.com \
--to=pabeni@redhat.com \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=cenzhang@linux.microsoft.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tom@herbertland.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox