From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next 2/2] inet: frags: fix ip6frag_low_thresh boundary Date: Wed, 4 Apr 2018 08:40:04 -0700 Message-ID: References: <20180404153510.213392-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev , Eric Dumazet To: Eric Dumazet , "David S . Miller" Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:39913 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbeDDPkG (ORCPT ); Wed, 4 Apr 2018 11:40:06 -0400 Received: by mail-pl0-f68.google.com with SMTP id s24-v6so14542048plq.6 for ; Wed, 04 Apr 2018 08:40:06 -0700 (PDT) In-Reply-To: <20180404153510.213392-1-edumazet@google.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 04/04/2018 08:35 AM, Eric Dumazet wrote: > Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, > since linker might place next to it a non zero value preventing a change > to ip6frag_low_thresh. > > ip6frag_low_thresh is not used anymore in the kernel, but we do not > want to prematuraly break user scripts wanting to change it. > > Since specifying a minimal value of 0 for proc_doulongvec_minmax() > is moot, let's remove these zero values in all defrag units. > > Fixes: 6e00f7dd5e4e ("ipv6: frags: fix /proc/sys/net/ipv6/ip6frag_low_thresh") > Signed-off-by: Eric Dumazet > Reported-by: Maciej Żenczykowski David, please ignore the net-next 2/2 in the title, there is a single patch, targeting net tree, sorry for the confusion.