From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes Date: Thu, 10 May 2018 09:19:28 -0500 Message-ID: References: <1a0d146dffb17449aa6d8a6b6d06e865e69226de.1525709213.git.swise@opengridcomputing.com> <06375fd7-f241-74ad-70ce-a670100bf060@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org To: David Ahern , leon@kernel.org Return-path: Received: from 72-48-214-68.dyn.grandenetworks.net ([72.48.214.68]:41150 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934609AbeEJO1U (ORCPT ); Thu, 10 May 2018 10:27:20 -0400 In-Reply-To: <06375fd7-f241-74ad-70ce-a670100bf060@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/9/2018 11:08 PM, David Ahern wrote: > On 5/7/18 9:53 AM, Steve Wise wrote: >> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >> pretty_output = true; >> break; >> case 'd': >> - show_details = true; >> + if (show_details) >> + show_driver_details = true; >> + else >> + show_details = true; >> break; >> case 'j': >> json_output = true; > The above change should be reflected in the man page. I did mention it in the man page:        -d, --details               Output detailed information.  Adding a second -d includes driver-specific details. But I wasn't sure how to show it in the syntax.  Maybe this?  OPTIONS := { -V[ersion] | -d[etails] [-d[etails]] } -j[son] } -p[retty] } > Also, the set needs to be respun after I merged master where Stephen > brought in updates to the uapi files. Will do.  Thanks for reviewing. Steve.