From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave Date: Mon, 26 Mar 2018 17:06:22 +0300 Message-ID: References: <8fd918da5a08f64dd69a45bcda3849bbd8114267.1521997984.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, Jiri Pirko , Wang Chen , Veaceslav Falico , Nikolay Aleksandrov To: Xin Long , network dev Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:50377 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbeCZOG0 (ORCPT ); Mon, 26 Mar 2018 10:06:26 -0400 Received: by mail-wm0-f65.google.com with SMTP id i75so15635215wmf.0 for ; Mon, 26 Mar 2018 07:06:25 -0700 (PDT) In-Reply-To: <8fd918da5a08f64dd69a45bcda3849bbd8114267.1521997984.git.lucien.xin@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 25/03/18 20:16, Xin Long wrote: > vlan_vids_add_by_dev is called right after dev hwaddr sync, so on > the err path it should unsync dev hwaddr. Otherwise, the slave > dev's hwaddr will never be unsync when this err happens. > > Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions with the standard ones") > Signed-off-by: Xin Long > --- > drivers/net/bonding/bond_main.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > Seems I've missed the err path back then. Thanks, Reviewed-by: Nikolay Aleksandrov