From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jiri Slaby <jirislaby@kernel.org>, netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 1/3] mctp: serial: cancel tx work on ldisc close
Date: Wed, 24 Nov 2021 14:38:57 +0800 [thread overview]
Message-ID: <e97b2d3ee72ba8eec5fbae81ce0757806bf25d69.camel@codeconstruct.com.au> (raw)
In-Reply-To: <b3307219-db82-d519-63df-dc246e11b037@kernel.org>
Hi Jiri,
> > + cancel_work_sync(&dev->tx_work);
>
> But the work still can be queued after the cancel (and before the
> unregister), right?
Yes. Yes it can.
I should be cancelling after the unregister, not before, so this'll need
a v2.
On the ldisc side: is there any case where we'd get a write wakeup
during (or after) the ->close()?
Cheers,
Jeremy
next prev parent reply other threads:[~2021-11-24 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 12:50 [PATCH net-next 0/3] mctp serial minor fixes Jeremy Kerr
2021-11-23 12:50 ` [PATCH net-next 1/3] mctp: serial: cancel tx work on ldisc close Jeremy Kerr
2021-11-24 5:36 ` Jiri Slaby
2021-11-24 6:35 ` Jiri Slaby
2021-11-24 6:38 ` Jeremy Kerr [this message]
2021-11-25 5:43 ` Jiri Slaby
2021-11-25 5:55 ` Jeremy Kerr
2021-11-23 12:50 ` [PATCH net-next 2/3] mctp: serial: enforce fixed MTU Jeremy Kerr
2021-11-23 12:50 ` [PATCH net-next 3/3] mctp: serial: remove unnecessary ldisc data check Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e97b2d3ee72ba8eec5fbae81ce0757806bf25d69.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).