From: Eric Dumazet <eric.dumazet@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, soheil@google.com,
jonathan.lemon@gmail.com, Willem de Bruijn <willemb@google.com>,
Talal Ahmad <talalahmad@google.com>
Subject: Re: [PATCH net] skbuff: fix incorrect msg_zerocopy copy notifications
Date: Thu, 10 Jun 2021 16:03:05 +0200 [thread overview]
Message-ID: <e9b3d5a9-96b4-f857-e9b8-82f1e3c49c1d@gmail.com> (raw)
In-Reply-To: <20210609224157.1800831-1-willemdebruijn.kernel@gmail.com>
On 6/10/21 12:41 AM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> msg_zerocopy signals if a send operation required copying with a flag
> in serr->ee.ee_code.
>
> This field can be incorrect as of the below commit, as a result of
> both structs uarg and serr pointing into the same skb->cb[].
>
> uarg->zerocopy must be read before skb->cb[] is reinitialized to hold
> serr. Similar to other fields len, hi and lo, use a local variable to
> temporarily hold the value.
>
> This was not a problem before, when the value was passed as a function
> argument.
>
> Fixes: 75518851a2a0 ("skbuff: Push status and refcounts into sock_zerocopy_callback")
> Reported-by: Talal Ahmad <talalahmad@google.com>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2021-06-10 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 22:41 [PATCH net] skbuff: fix incorrect msg_zerocopy copy notifications Willem de Bruijn
2021-06-10 0:17 ` Soheil Hassas Yeganeh
2021-06-10 14:03 ` Eric Dumazet [this message]
2021-06-10 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9b3d5a9-96b4-f857-e9b8-82f1e3c49c1d@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=talalahmad@google.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).