From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8811DC433F5 for ; Fri, 22 Apr 2022 20:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbiDVUTF (ORCPT ); Fri, 22 Apr 2022 16:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbiDVUTD (ORCPT ); Fri, 22 Apr 2022 16:19:03 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C551388E88 for ; Fri, 22 Apr 2022 13:13:29 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id y32so16143328lfa.6 for ; Fri, 22 Apr 2022 13:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=B9p0FoMPwzRixWYKVWEjx56sWOvt3enSLFG849SajN4=; b=i1xRqM/AQD7+zHlviCXpKPZZPH+NCey1cLY0YH9FoGiR73p/X6PTLSYWksAgy2XKmM ksiRnL7gx+oyU+FNTO7SF58wlUemyiGD7RFZqO8+RoT1p8NIqoBwjr6bNOASrAsJ1UPa YEjor8or6jM8yb19a+Jv4wMbSUGBGFj1fsk8zUp+BhH4KT4geUPppJf+2cvULcwK594C Ify1KqH7eFxQGny0PELELVDTWBxzSbVh/a4r+fXHN5VQ7XPgWdPBC0veaqgeUbtBqSrI TFb6ms3NcP0CuGTa6PRcEB1utLkbyV3aUe24o+fgprm8x3rB5dwmvLiOnq5fX0atxqYg xUkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=B9p0FoMPwzRixWYKVWEjx56sWOvt3enSLFG849SajN4=; b=GqLg2yihGmCvB3j0awUP3jJ/c3rxdhM5FjnWoYqXhePejeoI8uxT4t7TJzC+eHjUql Pe1aZcqWHLrNWtjNACUB+pAA6nM/qPGun7/hjiO9Ez59hfiyVxeR5TIzU8g1PR6zLQYY VUULh9nHmwrWO63TI71bhKRjDvTC5QxTdnmLu6XqgYNktxB/JN3s8hUysmxdiE9UGxCp 2gUNoADoTp/Dk+UiVjk49AFTdXNSevmnGQjgnH8MDVmoOUi1UkFPMEMfaTLVSM15DWdG NHUA7QcqLuR5lJ/st6OyUp2HigqS720k8xitqOGgcHaMUUvdznpI5jaPeHA2AUqnvoNP YjvQ== X-Gm-Message-State: AOAM532NEYStxmukfgZPD5KMdWieGcWxRoRek9NuEjEPeoiisM50hImD /ffU7vm8LjSE8/HXNyc+3YhAVg== X-Google-Smtp-Source: ABdhPJz/mlC+Za21idKmy1zP+GP4v28p+hBhHjrN0L2KdLEv46MDpRrVxcDXms2OUW+ufgEbuzzWAQ== X-Received: by 2002:a19:6759:0:b0:46b:b99f:a7ac with SMTP id e25-20020a196759000000b0046bb99fa7acmr4160108lfj.312.1650658143962; Fri, 22 Apr 2022 13:09:03 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.177]) by smtp.gmail.com with ESMTPSA id a12-20020a19fc0c000000b00471c63ea0fcsm336510lfi.6.2022.04.22.13.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 13:09:03 -0700 (PDT) Message-ID: Date: Fri, 22 Apr 2022 23:09:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH memcg RFC] net: set proper memcg for net_init hooks allocations Content-Language: en-US From: Vasily Averin To: Shakeel Butt Cc: Vlastimil Babka , Roman Gushchin , kernel@openvz.org, LKML , netdev , Cgroups , Michal Hocko , Florian Westphal , "David S. Miller" , Jakub Kicinski , Paolo Abeni References: <46c1c59e-1368-620d-e57a-f35c2c82084d@linux.dev> <55605876-d05a-8be3-a6ae-ec26de9ee178@openvz.org> <964ae72a-0484-67de-8143-a9a2d492a520@openvz.org> In-Reply-To: <964ae72a-0484-67de-8143-a9a2d492a520@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/22/22 23:01, Vasily Averin wrote: > On 4/21/22 18:56, Shakeel Butt wrote: >> On Sat, Apr 16, 2022 at 11:39 PM Vasily Averin wrote: >>> @@ -1147,7 +1148,13 @@ static int __register_pernet_operations(struct list_head *list, >>> * setup_net() and cleanup_net() are not possible. >>> */ >>> for_each_net(net) { >>> + struct mem_cgroup *old, *memcg = NULL; >>> +#ifdef CONFIG_MEMCG >>> + memcg = (net == &init_net) ? root_mem_cgroup : mem_cgroup_from_obj(net); >> >> memcg from obj is unstable, so you need a reference on memcg. You can >> introduce get_mem_cgroup_from_kmem() which works for both >> MEMCG_DATA_OBJCGS and MEMCG_DATA_KMEM. For uncharged objects (like >> init_net) it should return NULL. > > Could you please elaborate with more details? > It seems to me mem_cgroup_from_obj() does everything exactly as you say: > - for slab objects it returns memcg taken from according slab->memcg_data > - for ex-slab objects (i.e. page->memcg_data & MEMCG_DATA_OBJCGS) > page_memcg_check() returns NULL > - for kmem objects (i.e. page->memcg_data & MEMCG_DATA_KMEM) > page_memcg_check() returns objcg->memcg > - in another cases > page_memcg_check() returns page->memcg_data, > so for uncharged objects like init_net NULL should be returned. > > I can introduce exported get_mem_cgroup_from_kmem(), however it should only > call mem_cgroup_from_obj(), perhaps under read_rcu_lock/unlock. I think I finally got your point: Do you mean I should use css_tryget(&memcg->css) for found memcg, like get_mem_cgroup_from_mm() does? Thank you, Vasily Averin