From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
mptcp@lists.01.org, Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx path
Date: Mon, 30 Nov 2020 15:44:54 -0800 (PST) [thread overview]
Message-ID: <e9ef28f7-814a-1a86-9337-a7d2eddb7754@linux.intel.com> (raw)
In-Reply-To: <46e049b7bf734ed50f5b3c3762ee0278a682c66e.1606413118.git.pabeni@redhat.com>
On Fri, 27 Nov 2020, Paolo Abeni wrote:
> Extending the data_lock scope in mptcp_incoming_option
> we can use that to protect both snd_una and wnd_end.
> In the typical case, we will have a single atomic op instead of 2
>
> Acked-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/mptcp/mptcp_diag.c | 2 +-
> net/mptcp/options.c | 33 +++++++++++++--------------------
> net/mptcp/protocol.c | 34 ++++++++++++++++------------------
> net/mptcp/protocol.h | 8 ++++----
> 4 files changed, 34 insertions(+), 43 deletions(-)
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2020-11-30 23:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 10:10 [PATCH net-next 0/6] mptcp: avoid workqueue usage for data Paolo Abeni
2020-11-27 10:10 ` [PATCH net-next 1/6] mptcp: open code mptcp variant for lock_sock Paolo Abeni
2020-11-30 23:43 ` Mat Martineau
2020-11-27 10:10 ` [PATCH net-next 2/6] mptcp: implement wmem reservation Paolo Abeni
2020-11-30 23:43 ` Mat Martineau
2020-11-27 10:10 ` [PATCH net-next 3/6] mptcp: protect the rx path with the msk socket spinlock Paolo Abeni
2020-11-30 23:43 ` Mat Martineau
2020-11-27 10:10 ` [PATCH net-next 4/6] mptcp: allocate TX skbs in msk context Paolo Abeni
2020-11-30 23:44 ` Mat Martineau
2020-11-27 10:10 ` [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx path Paolo Abeni
2020-11-30 23:44 ` Mat Martineau [this message]
2020-11-27 10:10 ` [PATCH net-next 6/6] mptcp: use mptcp release_cb for delayed tasks Paolo Abeni
2020-11-30 23:45 ` Mat Martineau
2020-12-01 2:34 ` [PATCH net-next 0/6] mptcp: avoid workqueue usage for data Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9ef28f7-814a-1a86-9337-a7d2eddb7754@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).