From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 882F4C63777 for ; Mon, 30 Nov 2020 23:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3323520705 for ; Mon, 30 Nov 2020 23:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730591AbgK3Xqh (ORCPT ); Mon, 30 Nov 2020 18:46:37 -0500 Received: from mga12.intel.com ([192.55.52.136]:40000 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbgK3Xqg (ORCPT ); Mon, 30 Nov 2020 18:46:36 -0500 IronPort-SDR: 6CHJ16Bo+JU0xsPkx2bxzwNyuvLeGqmCZNApl7VcrNF1IFZ9JU3R8TQJyZCcYABtpwoyk8anh7 gRp/BuLkXNKg== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="151984997" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="151984997" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 15:44:56 -0800 IronPort-SDR: O01TZlnHsGEuDYR+LT0SQzIkOgjBKtCKrWuWJq4Xx4LZQQM1eVpe2XVPambI7viU6xLumRudZ+ cLO871bfkzSg== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="480855930" Received: from cdhirema-mobl5.amr.corp.intel.com ([10.254.71.173]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 15:44:55 -0800 Date: Mon, 30 Nov 2020 15:44:54 -0800 (PST) From: Mat Martineau To: Paolo Abeni cc: netdev@vger.kernel.org, Jakub Kicinski , mptcp@lists.01.org, Eric Dumazet Subject: Re: [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx path In-Reply-To: <46e049b7bf734ed50f5b3c3762ee0278a682c66e.1606413118.git.pabeni@redhat.com> Message-ID: References: <46e049b7bf734ed50f5b3c3762ee0278a682c66e.1606413118.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 27 Nov 2020, Paolo Abeni wrote: > Extending the data_lock scope in mptcp_incoming_option > we can use that to protect both snd_una and wnd_end. > In the typical case, we will have a single atomic op instead of 2 > > Acked-by: Florian Westphal > Signed-off-by: Paolo Abeni > --- > net/mptcp/mptcp_diag.c | 2 +- > net/mptcp/options.c | 33 +++++++++++++-------------------- > net/mptcp/protocol.c | 34 ++++++++++++++++------------------ > net/mptcp/protocol.h | 8 ++++---- > 4 files changed, 34 insertions(+), 43 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel