netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: netdev@vger.kernel.org, Matt Johnston <matt@codeconstruct.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v3] mctp: Implement extended addressing
Date: Thu, 21 Oct 2021 11:45:36 +0800	[thread overview]
Message-ID: <e9f97a8d9cf10537de4dcd38b666b6ccba5078a6.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20211015134448.GA16157@asgard.redhat.com>

Hi Eugene,

> So, unless there is existing code that relies on this socket level
> definition, it is probably worth re-defining it to 284 and put a copy
> of SOL_MCTP definition after SOL_XDP in include/linux/socket.h.

Nope, new ABI here, so we're fine to define it as we like.

I've sent a v4 with this moved to linux/socket.h, and dropped the uapi
definition - as (like you've mentioned) there's not a lot of precedent
for the copies under uapi.

Thanks for the review!

Cheers,


Jeremy


      reply	other threads:[~2021-10-21  3:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  8:34 [PATCH net-next v3] mctp: Implement extended addressing Jeremy Kerr
2021-10-15 13:44 ` Eugene Syromiatnikov
2021-10-21  3:45   ` Jeremy Kerr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9f97a8d9cf10537de4dcd38b666b6ccba5078a6.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=esyr@redhat.com \
    --cc=kuba@kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).